After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719890 - videodecoder: Add API to get the currently pending, parsed frame size
videodecoder: Add API to get the currently pending, parsed frame size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-05 10:15 UTC by Sebastian Dröge (slomo)
Modified: 2014-01-18 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videodecoder: Add API to get the parse adapter that contains already parsed data of a frame (4.53 KB, patch)
2013-12-05 10:16 UTC, Sebastian Dröge (slomo)
rejected Details | Review
openexrdec: Don't start scanning for the header from the start again each time (3.76 KB, patch)
2013-12-05 10:16 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2013-12-05 10:15:51 UTC
See attached patches. Without this the subclass has no idea how much was parsed already and will have to parse a frame over and over again until it is complete if there's no size header at the beginning.
Comment 1 Sebastian Dröge (slomo) 2013-12-05 10:16:15 UTC
Created attachment 263567 [details] [review]
videodecoder: Add API to get the parse adapter that contains already parsed data of a frame
Comment 2 Sebastian Dröge (slomo) 2013-12-05 10:16:27 UTC
Created attachment 263568 [details] [review]
openexrdec: Don't start scanning for the header from the start again each time

This will be incredible slow if the upstream block size is very small. Instead
continue scanning for the header where we previously stopped.
Comment 3 Sebastian Dröge (slomo) 2014-01-18 12:58:09 UTC
commit 87829debe49317829a18f9972184b43148b2c9f4
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Jan 18 13:54:22 2014 +0100

    videodecoder: Add API to get the currently pending frame size for parsing
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719890


commit 7548d5f7f9e9687260cd33b01bc382555fdbe73c
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sat Jan 18 13:56:28 2014 +0100

    openexrdec: Don't start scanning for the header from the start again each time
    
    This will be incredible slow if the upstream block size is very small. Instead
    continue scanning for the header where we previously stopped.
    
    For the standard filesrc block-size this made decoding a file about
    3 times faster.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719890