After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719850 - convertframe: remove trivial memory leak
convertframe: remove trivial memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Mac OS
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-04 15:38 UTC by Justin Kim
Modified: 2013-12-04 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a trivial memory leakage (1.28 KB, patch)
2013-12-04 15:39 UTC, Justin Kim 		reviewed Details | Review
GST_ELEMENT_NAME (859 bytes, patch)
2013-12-04 16:56 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2013-12-04 15:38:29 UTC 
I found a very trivial leak from convertframe, but nobody reported for a long time.
Comment 1 Justin Kim 2013-12-04 15:39:46 UTC 
Created attachment 263515 [details] [review]
a trivial memory leakage
Comment 2 Sebastian Dröge (slomo) 2013-12-04 15:42:06 UTC 
Or you just use GST_ELEMENT_NAME()
Comment 3 Justin Kim 2013-12-04 16:56:02 UTC 
Created attachment 263518 [details] [review]
GST_ELEMENT_NAME

Thanks for reminding MACRO.
Comment 4 Nicolas Dufresne (ndufresne) 2013-12-04 17:01:03 UTC 
Review of attachment 263518 [details] [review]:

Looks good, maybe a butter comment ? and we would be done, nice catch.
Comment 5 Nicolas Dufresne (ndufresne) 2013-12-04 17:01:25 UTC 
* better
Comment 6 Sebastian Dröge (slomo) 2013-12-04 17:04:12 UTC 
commit 4a81e22607ddefb8d05cd8587ac895f350359f6a
Author: Justin Joy <justin.joy.9to5@gmail.com>
Date:   Thu Dec 5 00:27:14 2013 +0900

    convertframe: Fix trivial memory leak in debug statement
    
    gst_element_get_name() requires the caller to g_free() the return value
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719850