After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719836 - Client side decorations cannot be deactivated with wayland backend
Client side decorations cannot be deactivated with wayland backend
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-12-04 11:53 UTC by Lionel Landwerlin
Modified: 2013-12-04 17:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
enable client side decorations deactivation with wayland backend (1.56 KB, patch)
2013-12-04 11:53 UTC, Lionel Landwerlin 		needs-work Details | Review
enable client side decorations deactivation with wayland backend (1.45 KB, patch)
2013-12-04 15:20 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2013-12-04 11:53:17 UTC 
I understand it has been chosen to make client side decoration in the wayland backend enabled by default. Some compositors (esoteric ones I concede) might choose not to do so.
Attached is a patch to let wayland decorations enabled by default but deactivated if explicitly deactivated by the GTK_CSD environment variable.
Comment 1 Lionel Landwerlin 2013-12-04 11:53:55 UTC 
Created attachment 263503 [details] [review]
enable client side decorations deactivation with wayland backend
Comment 2 Matthias Clasen 2013-12-04 15:10:59 UTC 
Review of attachment 263503 [details] [review]:

::: gtk/gtkwindow.c
@@ +5407,3 @@
+  csd_env = g_getenv ("GTK_CSD");
+  csd_described = csd_env != NULL;
+  csd_enabled = g_strcmp0 (g_getenv ("GTK_CSD"), "1") == 0;

Cosmetics, but I think csd_described is an odd name. I'd just use

g_strcmp0 (csd_env, "0") == 0

directly in the wayland clause below
Comment 3 Lionel Landwerlin 2013-12-04 15:20:03 UTC 
Created attachment 263514 [details] [review]
enable client side decorations deactivation with wayland backend
Comment 4 Matthias Clasen 2013-12-04 15:47:31 UTC 
Review of attachment 263514 [details] [review]:

looks good now, thanks