After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719781 - Hardcoded assumption of libEMF headers location
Hardcoded assumption of libEMF headers location
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
0.97.x
Other Mac OS
: Normal normal
: 0.98
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-03 15:29 UTC by Daniel Macks
Modified: 2014-01-04 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use libEMF/emf.h instead of -I/usr/include/libEMF (1.55 KB, patch)
2013-12-03 16:06 UTC, Daniel Macks
none Details | Review

Description Daniel Macks 2013-12-03 15:29:04 UTC
When checking for libEMF, configure.in (dia-0.97.2, and similar in git master) has line 224:

	CPPFLAGS="${CPPFLAGS} -I /usr/include/libEMF"

And then a few lines later:

		LIBEMF_CFLAGS='-I /usr/include/libEMF'

First, it's not correct to have whitespace between the -I flag and the pathname (syntax mistake that "some" compilers tolerate).

But it's also logically flawed because it assumes my libEMF is part of my vendor base system (rather than in /usr/local or some other location). That library appears to keep all its headers in the libEMF subdir. But also it appears to know that, and emf.h loads its other .h with that subdir (for example #include <libEMF/wine/windef.h>), so that extra -I shouldn't be needed if dia accesses emf.h as libEMF/emf.h directly.
Comment 1 Daniel Macks 2013-12-03 16:06:51 UTC
Created attachment 263402 [details] [review]
Use libEMF/emf.h instead of -I/usr/include/libEMF
Comment 2 Hans Breuer 2014-01-04 14:16:26 UTC
Thanks, pushed to master:
https://git.gnome.org/browse/dia/commit/?id=65822bb7e638093a4bc88b0e3763396ac8501537