GNOME Bugzilla – Bug 719781
Hardcoded assumption of libEMF headers location
Last modified: 2014-01-04 14:16:26 UTC
When checking for libEMF, configure.in (dia-0.97.2, and similar in git master) has line 224: CPPFLAGS="${CPPFLAGS} -I /usr/include/libEMF" And then a few lines later: LIBEMF_CFLAGS='-I /usr/include/libEMF' First, it's not correct to have whitespace between the -I flag and the pathname (syntax mistake that "some" compilers tolerate). But it's also logically flawed because it assumes my libEMF is part of my vendor base system (rather than in /usr/local or some other location). That library appears to keep all its headers in the libEMF subdir. But also it appears to know that, and emf.h loads its other .h with that subdir (for example #include <libEMF/wine/windef.h>), so that extra -I shouldn't be needed if dia accesses emf.h as libEMF/emf.h directly.
Created attachment 263402 [details] [review] Use libEMF/emf.h instead of -I/usr/include/libEMF
Thanks, pushed to master: https://git.gnome.org/browse/dia/commit/?id=65822bb7e638093a4bc88b0e3763396ac8501537