After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719731 - Various actions should be inactive when no image is opened
Various actions should be inactive when no image is opened
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2013-12-02 23:01 UTC by Jehan
Modified: 2013-12-03 00:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make inactive some actions when no image. (3.78 KB, patch)
2013-12-02 23:01 UTC, Jehan 		none Details | Review

Description Jehan 2013-12-02 23:01:38 UTC 
Created attachment 263350 [details] [review]
Make inactive some actions when no image.

Téo noticed in tito (bug 708174, comment 32) that some actions should not be active while there is no image. And indeed they do display critical warnings in the terminal if I try to run them.

The attached patch deactivate a few of them when no image is opened: file-save-and-close and a bunch of view-zoom-*

Note: about the view-zoom-*, there are a bunch which seems to be exactly the same! What is the difference between view-zoom-in and view-zoom-in-accel for instance?
Comment 1 Michael Natterer 2013-12-02 23:39:22 UTC 
That looks all correct, please push. The -accel actions simply add additional
shortcuts.
Comment 2 Jehan 2013-12-03 00:24:42 UTC 
commit 4e7bfb4e817ee6271497402d58d57ebf5bf2b533
Author: Jehan <jehan@girinstud.io>
Date:   Tue Dec 3 11:59:54 2013 +1300

    app: a bunch of actions which should be inactive when there is no image