GNOME Bugzilla – Bug 719727
glib-networking/connection.test /tls/connection/close-during-handshake busy loop
Last modified: 2014-01-20 17:17:47 UTC
Created attachment 263347 [details] backtrace This test appears to have several issues. First, I sometimes get a busy loop in at least the /tls/connection/close-during-handshake test, with the following trace:
Created attachment 263348 [details] trace Blah, keep forgetting gdb's "set logging on" appends.
The busy-wait means the test has failed. (It's waiting for another thread to do the final unref on an object; if it gets stuck looping that means something is unexpectedly holding an extra ref on the object). I guess I should add a timeout and make it fail properly.
Created attachment 263731 [details] [review] tls/tests/connection: don't spin waiting for shutdown to complete Rather than spinning forever waiting for variables to be unreffed by other threads, sleep for increasingly-long intervals until about 10 seconds pass, and then abort if the variable is still set. Addresses the current symptoms of https://bugzilla.gnome.org/show_bug.cgi?id=719727, but not the underlying leak that appears to be happening in some cases.
Review of attachment 263731 [details] [review]: OK; as long as we expect this to happen "reasonably quickly", the 10s timeout should be fine. But it is another potential source of race conditions as the VM running tests gets fully loaded.
Pushed. Leaving this bug open since it's presumably going to switch to "connection.test fails sporadically sometimes" now
figured out why it was failing, and fixed it *** This bug has been marked as a duplicate of bug 722336 ***