Created attachment 263342 [details] [review]
wayland: Fix setting keyboard focus for new clients

When we have a new client, we set the focus on one of its surfaces
when we map it but the client might not have called
wl_seat.get_keyboard yet. When it finally calls get_keyboard we must
then register its resource as the focus_resource which means that we
can only return early here if focus_resource is already set.

Review of attachment 263342 [details] [review]:

Yep.

Review of attachment 263342 [details] [review]:

By the way, does this also need to be fixed for the pointer as well?

Created attachment 263396 [details] [review]
window: Possibly set the pointer focus on newly mapped wayland windows

Windows showing up under the pointer must get the pointer focus.

--
(In reply to comment #3)
> By the way, does this also need to be fixed for the pointer as well?

Yes it does. In fact we were not even trying to set the pointer focus
on new windows.

Created attachment 263397 [details] [review]
wayland: Fix setting keyboard/pointer focus for new clients

When we have a new client, we potentially set the focus on one of its
surfaces when we map it but the client might not have called
wl_seat.get_keyboard/pointer yet. When it finally calls
get_keyboard/pointer we must then register its resource as the
focus_resource which means that we can only return early if
focus_resource is already set.

Review of attachment 263396 [details] [review]:

OK.

Review of attachment 263397 [details] [review]:

Yep.

Attachment 263396 [details] pushed as 3f022ca - window: Possibly set the pointer focus on newly mapped wayland windows
Attachment 263397 [details] pushed as 461f74e - wayland: Fix setting keyboard/pointer focus for new clients