GNOME Bugzilla – Bug 719721
renderer: Implement SetNextAVTransportURI
Last modified: 2014-01-23 13:07:22 UTC
This is based on the patch set in bug 709165.
Created attachment 263337 [details] [review] renderer: Implement SetNextAVTransportURI This is a simple implementation: It does not prefetch media. Things that will be tried on EOS or on "Next" action: * if there are songs to play on playlist, play next one * else if NEXTAVTransportURI is set, play that * else set state to "STOPPED" and track to 1.
Some open questions: * Is it really correct to start playing next-uri on "Next" action? I think it makes sense and a Microsoft test I found seems to agree, but the spec doesn't seem to explicitly say that... * For the next step: how should we implement the pre-fetching (which would be the obvious thing to do to get gapless playback)? GStreamer playbin has a "about-to-finish" signal where we could set uri to the next one we want to play and apparently that Just Works, but I don't think we can just make the MediaPlayer api like that... Maybe need to add next_uri/next_metadata property to MediaPlayer as well, so the implementations that want to pre-fetch uris can do so.
adding next_uri/next_metadata makes sense. Who should be responsible for setting uri/metatdata to next_uri/next_metadata? Did you try this with goldendmc?
Also, this patch is missing the modifications to AVTransport2.xml
Review of attachment 263337 [details] [review]: Added the AVTransport2.xml changes
This was committed back in December and seems to work. Enabling gapless playback seems a worthwhile goal, but I'll close this one and file a new bug for that.