After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719721 - renderer: Implement SetNextAVTransportURI
renderer: Implement SetNextAVTransportURI
Product: rygel
Classification: Applications
Component: librygel-renderer
Other All
: Normal normal
: ---
Assigned To: rygel-maint
Depends on: 709165
Reported: 2013-12-02 19:56 UTC by Jussi Kukkonen
Modified: 2014-01-23 13:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

renderer: Implement SetNextAVTransportURI (12.40 KB, patch)
2013-12-02 19:56 UTC, Jussi Kukkonen
committed Details | Review

Description Jussi Kukkonen 2013-12-02 19:56:26 UTC
This is based on the patch set in bug 709165.
Comment 1 Jussi Kukkonen 2013-12-02 19:56:28 UTC
Created attachment 263337 [details] [review]
renderer: Implement SetNextAVTransportURI

This is a simple implementation: It does not prefetch media.

Things that will be tried on EOS or on "Next" action:
 * if there are songs to play on playlist, play next one
 * else if NEXTAVTransportURI is set, play that
 * else set state to "STOPPED" and track to 1.
Comment 2 Jussi Kukkonen 2013-12-02 20:16:59 UTC
Some open questions:

* Is it really correct to start playing next-uri on "Next" action? I think it makes sense and a Microsoft test I found seems to agree, but the spec doesn't seem to explicitly say that...

* For the next step: how should we implement the pre-fetching (which would be the obvious thing to do to get gapless playback)? GStreamer playbin has a "about-to-finish" signal where we could set uri to the next one we want to play and apparently that Just Works, but I don't think we can just make the MediaPlayer api like that... Maybe need to add next_uri/next_metadata property to MediaPlayer as well, so the implementations that want to pre-fetch uris can do so.
Comment 3 Jens Georg 2013-12-14 15:51:29 UTC
adding next_uri/next_metadata makes sense. Who should be responsible for setting uri/metatdata to next_uri/next_metadata?

Did you try this with goldendmc?
Comment 4 Jens Georg 2013-12-14 15:55:54 UTC
Also, this patch is missing the modifications to AVTransport2.xml
Comment 5 Jens Georg 2013-12-14 16:18:15 UTC
Review of attachment 263337 [details] [review]:

Added the AVTransport2.xml changes
Comment 6 Jussi Kukkonen 2014-01-23 13:07:22 UTC
This was committed back in December and seems to work. Enabling gapless playback seems a worthwhile goal, but I'll close this one and file a new bug for that.