After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719701 - clear the "target" actor background in the calibration UI
clear the "target" actor background in the calibration UI
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-02 17:08 UTC by Carlos Garnacho
Modified: 2013-12-16 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Clear background on "target" actor in calibration UI (1.12 KB, patch)
2013-12-02 17:08 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2013-12-02 17:08:05 UTC 
The actor that shows the "target" on the tap area doesn't currently clear its background. This works fine on the first run as the surface backing it is freshly created. But on subsequent runs of the calibration UI, the surface seems to be reused from previous actors' cached surfaces, but it's still not cleared. This leads to growing artifacts on the actor the more times the calibration UI is run.
Comment 1 Carlos Garnacho 2013-12-02 17:08:44 UTC 
Created attachment 263316 [details] [review]
wacom: Clear background on "target" actor in calibration UI

the actor's draw() method isn't guaranteed to get a pristine surface,
which may cause artifacts if the background is left untouched, so
clear the background each time the actor has to be drawn.
Comment 2 Bastien Nocera 2013-12-13 16:45:12 UTC 
Review of attachment 263316 [details] [review]:

Looks good.
Comment 3 Carlos Garnacho 2013-12-16 11:39:48 UTC 
Attachment 263316 [details] pushed as 71945b8 - wacom: Clear background on "target" actor in calibration UI