GNOME Bugzilla – Bug 719698
Fix animations on the calibration UI
Last modified: 2013-12-16 12:08:29 UTC
The way the calibration UI deals with animations has several inconsistencies, which makes some of those animations to be initiated multiple times, leak and/or crash (the latter if the dialog gets destroyed early enough) I'm attaching a few patches to improve the way animations are done in the calibration UI
Created attachment 263312 [details] [review] wacom: Don't leave stray timelines on the calibration UI Keep the reference for the error/helper messages animations in the CalibArea struct, so those are destroyed and not leaked, or possibly crashing when running on already destroyed actors if the dialog gets cancelled at the right time.
Created attachment 263313 [details] [review] wacom: Protect calibrator UI to spawn animations multiple times The window state may be updated more than once, so only initiate the UI and animations when it's first called.
Created attachment 263314 [details] [review] wacom: Fix first animation of calibration UI The "target" was seen moving from 0,0 to the first calibration point, so 1) avoid target relayouts when the window is still being positioned and 2) start the "target" actor as hidden so it isn't seen moving from anywhere when first shown.
Review of attachment 263312 [details] [review]: Looks good otherwise. For gnome-3-10 and master. ::: panels/wacom/calibrator/calibrator-gui.c @@ +157,3 @@ + if (area->error_msg_timeline) + clutter_timeline_stop (CLUTTER_TIMELINE (area->error_msg_timeline)); indentation. @@ +159,3 @@ + clutter_timeline_stop (CLUTTER_TIMELINE (area->error_msg_timeline)); + if (area->helper_msg_timeline) + clutter_timeline_stop (CLUTTER_TIMELINE (area->helper_msg_timeline)); ditto. @@ +801,2 @@ gtk_widget_destroy (area->window); + Whitespace change.
Review of attachment 263313 [details] [review]: Looks good.
Review of attachment 263314 [details] [review]: Looks good.
Attachment 263312 [details] pushed as 911518d - wacom: Don't leave stray timelines on the calibration UI Attachment 263313 [details] pushed as ee2afb9 - wacom: Protect calibrator UI to spawn animations multiple times Attachment 263314 [details] pushed as c78e22b - wacom: Fix first animation of calibration UI