After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719645 - configure: emit message when looking for yelp
configure: emit message when looking for yelp
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.20
Other All
: Normal enhancement
: 1.20
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-01 15:02 UTC by Sebastian Rasmussen
Modified: 2014-01-05 22:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch to emit log message when looking for yelp (860 bytes, patch)
2013-12-01 15:04 UTC, Sebastian Rasmussen
needs-work Details | Review
Proposed patch to emit log message when looking for yelp (786 bytes, patch)
2013-12-03 00:00 UTC, Sebastian Rasmussen
committed Details | Review
configure: print when checking for yelp-tools (834 bytes, patch)
2013-12-03 13:35 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Sebastian Rasmussen 2013-12-01 15:02:53 UTC
This is a simple enhancement to show whether yelp is considered to be available or not.
Comment 1 Sebastian Rasmussen 2013-12-01 15:04:08 UTC
Created attachment 263238 [details] [review]
Proposed patch to emit log message when looking for yelp
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2013-12-01 16:45:21 UTC
Review of attachment 263238 [details] [review]:

::: configure.ac
@@ +232,3 @@
+else
+  AC_MSG_RESULT([no])
+fi

AC_MSG_RESULT($have_yelp_tools)

the problem here is that 'YELP_HELP_INIT' expands to checks for itstool and xmllint, so the output becomes:
 
checking whether yelp exists... checking for itstool... itstool
checking for xmllint... xmllint
yes

I thing we need would only need some output for the have_yelp_tool=no case (if at all).
Comment 3 Sebastian Rasmussen 2013-12-03 00:00:39 UTC
Created attachment 263354 [details] [review]
Proposed patch to emit log message when looking for yelp

I improved the patch, and made the commit message more correct as well.
Sample output below.

without yelp:
  checking for yelp-tools... no

with yelp present:
  checking for yelp-tools... yes
  checking for itstool... itstool
  checking for xmllint... xmllint
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2013-12-03 13:35:16 UTC
The following fix has been pushed:
fc5a889 configure: print when checking for yelp-tools
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2013-12-03 13:35:26 UTC
Created attachment 263390 [details] [review]
configure: print when checking for yelp-tools