After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719628 - Pathbar disappears with long folder names
Pathbar disappears with long folder names
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Path Bar
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on: 313854
Blocks:
 
 
Reported: 2013-12-01 10:15 UTC by Daniel Schürmann
Modified: 2014-02-17 21:12 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
use natural_size patch (4.73 KB, patch)
2013-12-01 10:34 UTC, Daniel Schürmann
none Details | Review
ensures that allways two buttons are displayed (3.82 KB, patch)
2013-12-01 11:03 UTC, Daniel Schürmann
none Details | Review
ensures that allways two buttons are displayed (4.78 KB, patch)
2013-12-01 22:22 UTC, Daniel Schürmann
none Details | Review

Description Daniel Schürmann 2013-12-01 10:15:36 UTC
If you have a long folder name, it is ellipsized to NAUTILUS_PATH_BAR_BUTTON_MAX_WIDTH since 79157f5617886401379a724f8c526c430c4876a6 in nautilus 3.5.2.

But if the pathbar is smaller then NAUTILUS_PATH_BAR_BUTTON_MAX_WIDTH it still disappears. It seams that some of the code in the mentioned commit has no effect. 

I will prepare a patch, that uses the normal size instead of minimal size for path bar calculation. With it all pathbar buttons are ellipsized to hight * 2 if required.
Comment 1 Daniel Schürmann 2013-12-01 10:34:48 UTC
Created attachment 263226 [details] [review]
use natural_size patch
Comment 2 Daniel Schürmann 2013-12-01 11:03:43 UTC
Created attachment 263229 [details] [review]
ensures that allways two buttons are displayed

This patch is on top of the previous patch. 

If there is a long folder name, the patbar button will consume the whole space. 
no other button, probably needed for navigation is displayed. 

This patch displays allways two buttons if required. 
The space is somehow shared at 50 % between the two buttons.
Comment 3 Daniel Schürmann 2013-12-01 22:22:11 UTC
Created attachment 263256 [details] [review]
ensures that allways two buttons are displayed
Comment 4 Cosimo Cecchi 2014-02-17 21:07:16 UTC
I think this has been fixed now in git master by other commits and fixes in GtkHeaderBar.
Feel free to reopen if you can still reproduce the issue.
Comment 5 Milan Bouchet-Valat 2014-02-17 21:12:04 UTC
Good to hear, thanks! I'll check that.