After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719512 - Adapt to libosinfo 0.2.9 & make use of variant API
Adapt to libosinfo 0.2.9 & make use of variant API
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2013-11-28 20:23 UTC by Zeeshan Ali
Modified: 2013-11-29 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require libosinfo >= 0.2.9 (687 bytes, patch)
2013-11-28 20:23 UTC, Zeeshan Ali 		committed Details | Review
extract-iso: Use osinfo_db_identify_media (2.20 KB, patch)
2013-11-28 20:24 UTC, Zeeshan Ali 		committed Details | Review
extract-iso: Make use of OS variants (1.64 KB, patch)
2013-11-28 20:24 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2013-11-28 20:23:56 UTC 
Tracker has been using a very old libosinfo. The media detection function used from old libosinfo has been deprecated for a while now so we better update to a new version now and use the new API. The attached patches do that.

Moreover by bumping to the unreleased version, we can already start to make use of the new OS variant API. This way we will show more exact names to users, e.g 'Microsoft Windows 7 Professional' instead of 'Microsoft Windows 7'.
Comment 1 Zeeshan Ali 2013-11-28 20:23:58 UTC 
Created attachment 263068 [details] [review]
Require libosinfo >= 0.2.9
Comment 2 Zeeshan Ali 2013-11-28 20:24:05 UTC 
Created attachment 263069 [details] [review]
extract-iso: Use osinfo_db_identify_media

osinfo_db_guess_os_from_media is deprecated in newer libosinfo and
is replaced by osinfo_db_identify_media.
Comment 3 Zeeshan Ali 2013-11-28 20:24:09 UTC 
Created attachment 263070 [details] [review]
extract-iso: Make use of OS variants

Take the name of first variant as 'nie:title', if any.
Comment 4 Carlos Garnacho 2013-11-29 12:30:17 UTC 
I think it's all fine for master. IMO this is too much of a side feature to care about ifdefs, so please go ahead
Comment 5 Zeeshan Ali 2013-11-29 12:35:09 UTC 
Attachment 263068 [details] pushed as 209d489 - Require libosinfo >= 0.2.9
Attachment 263069 [details] pushed as 6c5ba40 - extract-iso: Use osinfo_db_identify_media
Attachment 263070 [details] pushed as 76df381 - extract-iso: Make use of OS variants