After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719508 - Need to add support to new AtkDocument signals and methods
Need to add support to new AtkDocument signals and methods
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: at-spi2-core
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-28 18:24 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2013-12-02 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
at-spi2-core: support to current page and page count (2.86 KB, patch)
2013-11-28 18:32 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review
at-spi2-atk: support for newly added AtkDocument methods and signals (4.19 KB, patch)
2013-11-28 18:40 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review
pyatspi2: patch (1.75 KB, patch)
2013-11-28 19:02 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00) 		committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-28 18:24:00 UTC 
Bug 709106 adds a new signal, document:page-changed.

Bug 709214 adds two new methods: get_current_page_number and get_page_count.

at-spi2-core and at-spi2-atk needs to support them in order to expose it to ATs
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-28 18:32:19 UTC 
Created attachment 263049 [details] [review]
at-spi2-core: support to current page and page count
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-28 18:40:42 UTC 
Created attachment 263054 [details] [review]
at-spi2-atk: support for newly added AtkDocument methods and signals

This patch does the following:
* Bump atk dependency to 2.11.3 (I just did it today in order to have a real atk release to depend on)
* Forward atk-document:page-changed signal
* Implement the getters for newly added at-spi2 properties CurrentPageNumber and PageCount
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2013-11-28 19:02:48 UTC 
Created attachment 263057 [details] [review]
pyatspi2: patch

DISCLAIMER: I was not able to test it. I implemented a python listener that tries to use the new added method but I was not able to get it using the pyatspi installed at jhbuild, it is getting the system one.

FWIW, at-spi2-core and at-spi2-atk patches are tested, as I used a listener written in C. FWIW2, it is really handy to test them using evince, with the patch I uploaded on bug 719507.
Comment 4 Mike Gorse 2013-12-02 17:18:53 UTC 
Comment on attachment 263049 [details] [review]
at-spi2-core: support to current page and page count

Looks fine. Thanks for the patch.