After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719457 - Template for Home Mortgage Loan isn't properly nested.
Template for Home Mortgage Loan isn't properly nested.
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: General
2.4.x
Other All
: Normal normal
: ---
Assigned To: gnucash-general-maint
gnucash-general-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-28 03:17 UTC by OSOFAST
Modified: 2018-06-29 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improperly Nested Loans (271.80 KB, image/jpeg)
2013-11-28 03:17 UTC, OSOFAST
  Details
Fix incorrect account nesting (5.09 KB, patch)
2014-05-09 23:07 UTC, Michalis
committed Details | Review
That patch should handle all remaining incorrect nestings (17.58 KB, patch)
2014-05-31 23:28 UTC, Michalis
committed Details | Review

Description OSOFAST 2013-11-28 03:17:14 UTC
Created attachment 262991 [details]
Improperly Nested Loans

A mortgage loan, which is a long term liability isn't correctly listed under liabilities in the Home Mortgage Loan template and is instead left floating uncategorized.

If we compare the Home Mortgage Loan template to the Car Loan template, you'll see how Loans should have fallen under liabilities. 

Screenshot showing Home Mortgage Loan accounts template on the left and Car Loan on the right is attached.

This is a recurring issue for many of the templates.
Comment 1 Michalis 2014-05-09 23:07:05 UTC
The problem exists in current master too. Several account templates contained accounts with two parents, resulting to incorrect nesting.
I fixed C and en_GB. 

The same problem exists in some of the account fils in :
ja, ko, lv, pl, ru, tr_TR, zh_CN 
but I didn't touch them because I was afraid that my editor (VI) would mess up with the special characters these files have, and I think they should be checked by the translators.
Comment 2 Michalis 2014-05-09 23:07:36 UTC
Created attachment 276265 [details] [review]
Fix incorrect account nesting
Comment 3 Geert Janssens 2014-05-20 21:37:36 UTC
Comment on attachment 276265 [details] [review]
Fix incorrect account nesting

Thank you for your patch. I have committed it to the maint branch.

As for the other account charts in other languages: you're welcome to change those as well, even if you can't read the foreign characters. Vi can handle these foreign charsets just fine and if you doubt this git diff will quickly tell you.

We could wait for translators to look at this but that will mean the bug will linger for a very long time as we don't have active translators for all the languages at present.
Comment 4 Michalis 2014-05-31 23:28:07 UTC
Created attachment 277641 [details] [review]
That patch should handle all remaining incorrect nestings
Comment 5 Geert Janssens 2014-06-09 18:28:11 UTC
Comment on attachment 277641 [details] [review]
That patch should handle all remaining incorrect nestings

Committed to maint. Thank you very much !
Comment 6 John Ralls 2017-09-24 22:50:00 UTC
Reassign version to 2.4.x so that individual 2.4 versions can be retired.
Comment 7 John Ralls 2018-06-29 23:22:02 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=719457. Please update any external references or bookmarks.