GNOME Bugzilla – Bug 719452
Provide proper error output if gobject-introspection-devel missing
Last modified: 2016-10-10 13:55:34 UTC
Fedora 19 Followed steps in the README file in git master. In autogen.sh I get: checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.9.0... yes ./configure: line 13654: syntax error near unexpected token `0.9.6' ./configure: line 13654: ` GOBJECT_INTROSPECTION_REQUIRE(0.9.6)' Expected output: A check for the gobject-introspection header file in pkgconfig folder, like: configure: error: Package requirements ( gobject-introspection >= ... ) were not met: No package 'gobject-introspection' found or ***Error***: You must have gobject-introspection >= ... installed to build gnome-music. Download the appropriate package for from your distribution or get the source tarball at http://ftp.gnome.org/pub/GNOME/sources/gobject-introspection/
Looks easy to fix, see https://git.gnome.org/browse/gnome-weather/tree/configure.ac#n37 for instance
Seems like it's in gnome-weather too: checking pkg-config is at least version 0.9.0... yes ./configure: line 13350: syntax error near unexpected token `0.9.6' ./configure: line 13350: ` GOBJECT_INTROSPECTION_REQUIRE(0.9.6)' Though I don't think we should fix this. This is the standard way to check for gobject-introspection, and modules usually assume that the person who clones from the git repositories already have it (especially those who use autogen.sh, since it needs gnome-autogen to run, which is included in gnome-common, which usually pulls gobject-introspection and other developer libraries that are common in many modules...). The GOBJECT_INTROSPECTION_REQUIRE macro is for tarball releases. If you build using the tarball, ./configure will check if you have gobject-introspection and prints a warning if you don't. A "fix" we could do is to list the dependencies in the README file.
Right, updating README should be enough (I image there'd be lots of similar situations if requirements are missing)
Removing the available whiteboard - we're not really using it any more.
Created attachment 331244 [details] [review] Added dependency list in the README file.
Review of attachment 331244 [details] [review]: As said on IRC, I don't think the README is the place for a complete list of deps. Maybe a few main deps like gstreamer/tracker/gobject-introspection/pygobject/grilo/gtk/python3 (what is referenced in the imports), but I'm on the fence about that as well. It's really a packagers thing in my opinion.. ::: README @@ +109,3 @@ +vala +wayland +wayland-protocols I'm pretty sure wayland isn't needed when on X.
I don't think updating README fixes the bug. The bug expects a more elaborate error message
Added AX_REQUIRE_DEFINED, I think that is as much as we can do here. See commit e9674fa1b5b0bedd28da977b125993d29e09596c . This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.