After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719434 - rtph264pay maps and unmaps inbuffer twice
rtph264pay maps and unmaps inbuffer twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-27 16:11 UTC by Jonas Holmberg
Modified: 2013-11-28 21:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Map inbuffer once only (1.65 KB, patch)
2013-11-27 16:13 UTC, Jonas Holmberg
committed Details | Review

Description Jonas Holmberg 2013-11-27 16:11:55 UTC
rtph264pay calls gst_buffer_extract() twice and each call will map and unmap the buffer.
Comment 1 Jonas Holmberg 2013-11-27 16:13:11 UTC
Created attachment 262959 [details] [review]
Map inbuffer once only

Do not call gst_buffer_extract() twice since each call will map and unmap the buffer.
Comment 2 Olivier Crête 2013-11-28 21:32:21 UTC
Comitted

commit 0ab0421759815e8f04e4e48ac81e25f7cf2c7288
Author: Jonas Holmberg <jonashg@axis.com>
Date:   Wed Nov 27 17:02:00 2013 +0100

    rtph264pay: Map inbuffer once only
    
    Do not call gst_buffer_extract() twice since each call will map and
    unmap the biffer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719434