After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719425 - Reverting documents doesn't take care of removing marks
Reverting documents doesn't take care of removing marks
Status: RESOLVED OBSOLETE
Product: gedit
Classification: Applications
Component: file loading and saving
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-27 14:53 UTC by Volker Sobek (weld)
Modified: 2020-11-24 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Volker Sobek (weld) 2013-11-27 14:53:17 UTC
The function gedit_document_output_stream_constructed in /gedit/gedit-document-output-stream.c does remove all text from the buffer, but doesn't take care of removing marks

	/* clear the buffer */
	gtk_text_buffer_set_text (GTK_TEXT_BUFFER (stream->priv->doc),
				  "", 0);

When plugins, like the bookmark plugin, place marks in the buffer, and only connect to the 'loaded' signal, they will leave marks in the buffer, since source marks survive deleting ranges.

Making plugins connect to the 'load' signal and remove the marks beforehand,or remove all marks at the 'loaded' signal, before loading the bookmarks again would be a solution too, but clearing the buffer properly in any case would be good anyway, I guess.
Comment 1 Sébastien Wilmet 2020-11-24 10:00:13 UTC
Mass-closing of all gedit bugzilla tickets.

Special "code" to find again all those gedit bugzilla tickets that were open before the mass-closing:

2bfe1b0590a78457e1f1a6a90fb975f5878cb60064ccfe1d7db76ca0da52f0f3

By searching the above sha256sum in bugzilla, the gedit contributors can find again the tickets. We may be interested to do so when we work on a specific area of the code, to at least know the known problems and possible enhancements.

We do this mass-closing because bugzilla.gnome.org is being replaced by gitlab.gnome.org.