After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719415 - rtpbasepayload: Expose running time of last processed buffer
rtpbasepayload: Expose running time of last processed buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-27 13:12 UTC by Sebastian Rasmussen
Modified: 2014-01-28 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch adding running time of last processed buffer. (4.51 KB, patch)
2013-11-27 13:13 UTC, Sebastian Rasmussen
none Details | Review
Proposed patch adding running time of last processed buffer. (4.51 KB, patch)
2013-11-30 01:05 UTC, Sebastian Rasmussen
none Details | Review
Proposed patch adding statistics property to basepayloader. (5.15 KB, patch)
2014-01-22 21:53 UTC, Sebastian Rasmussen
none Details | Review
Proposed patch adding running time of last processed buffer. (5.46 KB, patch)
2014-01-22 21:54 UTC, Sebastian Rasmussen
none Details | Review
Proposed patch adding running time of last processed buffer. (3.95 KB, patch)
2014-01-27 23:45 UTC, Sebastian Rasmussen
committed Details | Review

Description Sebastian Rasmussen 2013-11-27 13:12:25 UTC
The intent is to use this exposed running time when creating the RTP-Info header in gst-rtsp-server.
Comment 1 Sebastian Rasmussen 2013-11-27 13:13:26 UTC
Created attachment 262934 [details] [review]
Proposed patch adding running time of last processed buffer.
Comment 2 Sebastian Rasmussen 2013-11-30 01:05:09 UTC
Created attachment 263191 [details] [review]
Proposed patch adding running time of last processed buffer.

Fixed typo.
Comment 3 Sebastian Rasmussen 2013-12-10 00:45:15 UTC
I'll get back to this patch soon.
Comment 4 Sebastian Rasmussen 2014-01-22 21:53:30 UTC
Created attachment 267002 [details] [review]
Proposed patch adding statistics property to basepayloader.
Comment 5 Sebastian Rasmussen 2014-01-22 21:54:08 UTC
Created attachment 267003 [details] [review]
Proposed patch adding running time of last processed buffer.
Comment 6 Wim Taymans 2014-01-27 14:17:41 UTC
commit fa393e5d60bcb61ba0e48905b19a3b76847d31ee
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Thu Jan 16 21:49:59 2014 +0100

    rtpbasepayload: Add statistics property
    
    This property allows for an atomically retrieved set of properties that
    can e.g. be used to generate RTP-Info headers.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=719415
Comment 7 Wim Taymans 2014-01-27 14:18:10 UTC
Please remove the new property and rebase on top of current master.
Comment 8 Sebastian Rasmussen 2014-01-27 23:44:38 UTC
I assumed that the patches from https://bugzilla.gnome.org/show_bug.cgi?id=719383 would be applied before this patch series was. I've rebased this patch series against current master. The logging of the set running-time will not be as pretty because using current master I can't distinguish between the running-time when it is expressed in hz and ns (this is what 719383 provides). I'll solve that later in 719383.

I have now removed the property, let me know if you need anything further.
Comment 9 Sebastian Rasmussen 2014-01-27 23:45:20 UTC
Created attachment 267366 [details] [review]
Proposed patch adding running time of last processed buffer.
Comment 10 Wim Taymans 2014-01-28 13:43:59 UTC
commit 0142cd5e35b7fcb5232e35342052f540ca51f47e
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Tue Jan 28 00:40:38 2014 +0100

    rtpbasepayload: Expose running-time of payloaded stream
    
    https://bugzilla.gnome.org/show_bug.cgi?id=719415