After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719405 - uri-tester: Avoid critical when unref-ing NULL regex
uri-tester: Avoid critical when unref-ing NULL regex
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-27 10:53 UTC by Andres Gomez
Modified: 2013-11-27 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
uri-tester: Avoid critical when unref-ing NULL regex (803 bytes, patch)
2013-11-27 10:53 UTC, Andres Gomez
accepted-commit_now Details | Review

Description Andres Gomez 2013-11-27 10:53:28 UTC
When a regex compilation fails we get an error and NULL. No need to
unref the NULL pointer.
Comment 1 Andres Gomez 2013-11-27 10:53:31 UTC
Created attachment 262930 [details] [review]
uri-tester: Avoid critical when unref-ing NULL regex
Comment 2 Andres Gomez 2013-11-27 10:54:48 UTC
This is related to bug 719399.
Comment 3 Claudio Saavedra 2013-11-27 11:05:27 UTC
Review of attachment 262930 [details] [review]:

You can commit to the gnome-3-10 branch too.
Comment 4 Andres Gomez 2013-11-27 11:22:55 UTC
Pushed.