GNOME Bugzilla – Bug 719379
Send/Receive dialog doesn't close on errors properly
Last modified: 2014-07-04 08:43:49 UTC
When I click Send/Receive, the popup dialog shows my GOA-configured EWS account as "Scanning folders in '...'", but it never ends, instead, console contains a new runtime warning: > evolution-mail-WARNING **: receive_update_got_folderinfo: Invalid password > with username `mcrha' (goa-error-quark, 0): Code: 401 - Unexpected response > from server The receive_update_got_folderinfo() should propagate the error into UI and let the user know that there was an issue with the account, same as end the Send/Receive operation properly (I still can click 'Cancel' beside the "Scanning folders" operation for that account).
The Send/Receive dialog (mail-send-recv.c) is really old and needs a rewrite. This is just one of its problems. It's on my agenda for December.
I do not think that there is any need to rewrite it when the only issue is due to incorrect assumptions in the code, aka because there's a bug in the code. As I cannot add new strings into the stable branch I just fixed the bug in the code, thus the dialog properly closes now. Created commit 4cda728 in evo master (3.13.4+) [1] Created commit aab5e63 in evo evolution-3-12 (3.12.4+) I can add strings into the development version, thus let's propagate the errors into UI, instead on the console. Created commit ffc21b9 in evo master (3.13.4+) [2] [1] https://git.gnome.org/browse/evolution/commit/?id=4cda728 [2] https://git.gnome.org/browse/evolution/commit/?id=ffc21b9
(In reply to comment #2) > I can add strings into the development version, thus let's propagate the errors > into UI, instead on the console. > > Created commit ffc21b9 in evo master (3.13.4+) [2] Which caused bug 732724. Bad of me.