After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719378 - loginDialog: Implement cancel()
loginDialog: Implement cancel()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 715000 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-11-26 19:56 UTC by Florian Müllner
Modified: 2014-01-12 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loginDialog: Implement cancel() (926 bytes, patch)
2013-11-26 19:56 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-11-26 19:56:17 UTC 
Spotted in a downstream trace at https://bugzilla.redhat.com/show_bug.cgi?id=1034966
Comment 1 Florian Müllner 2013-11-26 19:56:20 UTC 
Created attachment 262895 [details] [review]
loginDialog: Implement cancel()

The screen shield expects a cancel() method on the unlockDialog
implementation, but LoginDialog does not provide it currently.
Comment 2 Ray Strode [halfline] 2013-11-27 05:41:56 UTC 
Review of attachment 262895 [details] [review]:

looks right.
Comment 3 Florian Müllner 2013-11-27 13:32:24 UTC 
Attachment 262895 [details] pushed as 729c962 - loginDialog: Implement cancel()
Comment 4 Florian Müllner 2014-01-12 23:39:06 UTC 
*** Bug 715000 has been marked as a duplicate of this bug. ***