After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719339 - rfkill: Add Bluetooth killswitch support
rfkill: Add Bluetooth killswitch support
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 719341
 
 
Reported: 2013-11-26 09:41 UTC by Bastien Nocera
Modified: 2013-11-26 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rfkill: Add Bluetooth killswitch support (7.81 KB, patch)
2013-11-26 09:41 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2013-11-26 09:41:28 UTC 
.
Comment 1 Bastien Nocera 2013-11-26 09:41:36 UTC 
Created attachment 262816 [details] [review]
rfkill: Add Bluetooth killswitch support
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-11-26 14:23:09 UTC 
Review of attachment 262816 [details] [review]:

::: plugins/rfkill/gsd-rfkill-manager.c
@@ +101,2 @@
 static gboolean
+engine_get_bluetooth_airplane_mode (GsdRfkillManager *manager)

This would probably be a bit cleaner with a helper method.

    any_killswitch_has_state (manager->priv->bt_killswitches, RFKILL_STATE_UNBLOCKED);

@@ +140,3 @@
+		/* A single rfkill switch that's not hw blocked? Hw airplane mode is off */
+		if (state != RFKILL_STATE_HARD_BLOCKED) {
+			return FALSE;

Should this not have braces, or should the method above not have it?
Comment 3 Bastien Nocera 2013-11-26 16:50:33 UTC 
Fixed the comments in subsequent patches.