---- Reported by shotwell-maint@gnome.bugs 2013-01-29 01:20:00 -0800 ----

Original Redmine bug id: 6275
Original URL: http://redmine.yorba.org/issues/6275
Searchable id: yorba-bug-6275
Original author: Jens B
Original description:

Hi,

I think it would be great for Shotwell to have the ability for random
slideshow transitions.

I have attached a simple, but working implementation in SlideshowPage.vala and
TransitionEffects.vala using a RandomEffectDescriptor to provide a menu entry
and id, then check in SlideshowPage on_next_photo() check for that id beeing
the currently selected Transition, if so randomize the next transition.

I guess it isn't very good, as I am new to Vala, but maybe it is a starting
point



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 10 months ago

  * **Category** set to _library-mode_
  * **Status** changed from _Open_ to _Review_
  * **Assignee** set to _Jens B_

Hi Jens,

Thanks for the code. It would be better if you could send it to us in patch
format. An easy way to do that is using `git diff`. If you haven't committed
the changes to your local repo, you can add your code to the staging area
(`git add -u`) and then run `git diff --cached`.

####

#2

Updated by Jens B 10 months ago

  * **File** _0002-Add-Random-Effect-Transition.patch_ added

I've attached a patch, hope this works. If not, give me a bump.

####

#3

Updated by Jim Nelson 10 months ago

  * **Target version** set to _0.14.0_

This looks good, thanks Jens. We'll take a look at this shortly!

####

#4

Updated by Lucas Beeler 9 months ago

  * **Status** changed from _Review_ to _Open_

Hi Jens,

As you probably saw, we committed your additional slideshow effects patch this
morning. I particularly like the Blinds and Clock transitions. Anyway, as a
result of that, your patch here no longer applies. It's also 14 days old, and
I'll bet you've learned a lot about Vala, Shotwell and the Yorba coding
conventions since then, given your excellent work on the slideshow effects. So
could you submit an updated version of this patch diff'd against today's
master?

Lucas

####

#5

Updated by Jens B 9 months ago

  * **File** deleted (<strike>_SlideshowPage.vala_</strike>)

####

#6

Updated by Jens B 9 months ago

  * **File** deleted (<strike>_TransitionEffects.vala_</strike>)

####

#7

Updated by Jens B 9 months ago

  * **File** deleted (<strike>_0002-Add-Random-Effect-Transition.patch_</strike>)

####

#8

Updated by Jens B 9 months ago

  * **File** _0001-Add-Random-Transition-Effect.patch_ added

Hey,

I've attached a patch that applies to the current master. I tried to follow
the guides, however I'm not particulary happy with the way I handle the
Pluggables. However I don't know how to do this proberly as get_effect_ids()
returns an immutable list.

Maybe you can help me there?

####

#9

Updated by Jim Nelson 9 months ago

  * **Status** changed from _Open_ to _Review_

####

#10

Updated by Lucas Beeler 9 months ago

  * **Status** changed from _Review_ to _Open_

Hi Jens,

At SlideshowPage.vala:212-213 you've got these two lines:

    
    
    transition_count = a.size;
    transitions = a.to_array();
    

  
Note that the the transition_count variable is redundant -- after you've built
the transitions array, you should just be able to use transitions.length.

Make at least this change and check for other possible redundancies and send
me an updated diff. I'm looking forward to it!

####

#11

Updated by Jens B 9 months ago

  * **File** deleted (<strike>_0001-Add-Random-Transition-Effect.patch_</strike>)

####

#12

Updated by Jens B 9 months ago

  * **File** 0001-Add-Random-Transition-Effect.patch added

I fixed that, really stupid....

Hope it is ok now.

####

#13

Updated by Lucas Beeler 9 months ago

  * **Status** changed from _Open_ to _Review_

####

#14

Updated by Jim Nelson 9 months ago

  * **Keywords** set to _string-change_

####

#15

Updated by Jens B 9 months ago

  * **Status** changed from _Review_ to _5_

Applied in changeset 87fe246aef7aa0325e42cbcbf94c9383abe9e244.

####

#16

Updated by Lucas Beeler 9 months ago

  * **Resolution** set to _fixed_

####

#17

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC  ---

This bug was previously known as _bug_ 6275 at http://redmine.yorba.org/show_bug.cgi?id=6275
Imported an attachment (id=262658)

Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.