After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 718944 - Display state is wrong when "Adjust Date and Time..." dialog is opened
Display state is wrong when "Adjust Date and Time..." dialog is opened
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other All
: Normal normal
: 0.22
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-25 10:13 UTC by Lucas Beeler
Modified: 2015-03-11 20:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch set timeformat before setting the time (884 bytes, patch)
2015-03-08 18:24 UTC, Wolfgang Steitz
accepted-commit_now Details | Review

Description Charles Lindsay 2013-11-25 21:58:59 UTC


---- Reported by lucas@yorba.org 2013-03-25 15:13:00 -0700 ----

Original Redmine bug id: 6672
Original URL: http://redmine.yorba.org/issues/6672
Searchable id: yorba-bug-6672
Original author: Lucas Beeler
Original description:

For photos that have a time of exactly noon, when the "Adjust Date and
Time..." dialog is opened the display state of the time selector widgets
displays midnight (0:00) not noon (12:00) when in 24 hour mode.

Ticketed downstream here: https://bugs.launchpad.net/bugs/1159821



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:44:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 8 months ago

  * **Target version** changed from _0.15.0_ to _0.16.0_

####

#2

Updated by Jim Nelson 6 months ago

  * **Target version** deleted (<strike>_0.16.0_</strike>)



--- Bug imported by chaz@yorba.org 2013-11-25 21:59 UTC  ---

This bug was previously known as _bug_ 6672 at http://redmine.yorba.org/show_bug.cgi?id=6672

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Wolfgang Steitz 2015-03-08 18:24:43 UTC
Created attachment 298823 [details] [review]
patch set timeformat before setting the time

The attached patch fixes the issue, by simply setting the time format before setting the time. Doing it the other way around, converts the 12 to a zero.
Comment 2 Jim Nelson 2015-03-09 19:56:38 UTC
Review of attachment 298823 [details] [review]:

Good catch!  Can you commit?
Comment 3 Wolfgang Steitz 2015-03-11 20:23:31 UTC
I do! Pushed to master, commit ebe6722