After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 718817 - Missing ";" in po files for "GNOME Application Keywords" for "de", "es", "zh_TW" and "ar"
Missing ";" in po files for "GNOME Application Keywords" for "de", "es", "zh_...
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: general
0.13.1
Other All
: Urgent normal
: ---
Assigned To: clinton
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-20 01:24 UTC by Shotwell Maintainers
Modified: 2013-05-01 06:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
shotwell-0.13.0-po.patch (1.42 KB, patch)
2012-09-20 13:24 UTC, Shotwell Maintainers
none Details | Review
5860.patch (2.39 KB, patch)
2012-09-27 00:21 UTC, clinton
none Details | Review

Description Charles Lindsay 2013-11-25 21:58:05 UTC


---- Reported by shotwell-maint@gnome.bugs 2012-09-20 06:24:00 -0700 ----

Original Redmine bug id: 5860
Original URL: http://redmine.yorba.org/issues/5860
Searchable id: yorba-bug-5860
Original author: Damien Lallement
Original description:

Hi,

While building shotwell 0.13.0 for Mageia, I noticed:

Submission errors, aborting:

- shotwell-0.13.0-1.mga3:  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "Kamera;Bild;Foto" for locale string list key "Keywords[de]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "C?mara;Imagen;Foto" for locale string list key "Keywords[es]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "??;??;??;??" for locale string list key "Keywords[zh_TW]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "??????;????;???" for locale string list key "Keywords[ar]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "Kamera;Bild;Foto" for locale string list key "Keywords[de]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "C?mara;Imagen;Foto" for locale string list key "Keywords[es]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "??;??;??;??" for locale string list key "Keywords[zh_TW]" in group "Desktop Entry" does not have a semicolon (';') as trailing character  
- invalid-desktopfile /usr/share/applications/shotwell.desktop value "??????;????;???" for locale string list key "Keywords[ar]" in group "Desktop Entry" does not have a semicolon (';') as trailing character

FYI: http://pkgsubmit.mageia.org/uploads/rejected//cauldron/core/release/20120
920123125.dams.valstar.7478.youri)

Here is my patch for Mageia.

Related issues:
related to shotwell - 6560: Missing ";" in pt.po file for "GNOME
Application Keywords" (Fixed)
related to shotwell - 6570: Use desktop-file-validate in Makefile (Fixed)



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:38:00 -0700 ----

### History

####

#1

Updated by Adam Dingle about 1 year ago

  * **Assignee** set to _Lucas Beeler_
  * **Priority** changed from _High_ to _Urgent_

Thanks for the bug report. Lucas, let's discuss whether this warrants an
immediate 0.13.1 release.

####

#2

Updated by Adam Dingle about 1 year ago

  * **Assignee** changed from _Lucas Beeler_ to _Clinton Rogers_

####

#3

Updated by Clinton Rogers about 1 year ago

  * **File** 5860.patch added
  * **Status** changed from _Open_ to _Review_
  * **% Done** changed from _0_ to _70_

Went with something exactly like Damien's proposed patch (thanks!).

I also did a quick sweep of the .pot and the other .po files; no other issues
found.

####

#4

Updated by Clinton Rogers about 1 year ago

  * **Status** changed from _Review_ to _5_
  * **% Done** changed from _70_ to _100_
  * **Resolution** set to _fixed_

4c79ab6bc9c1c4e5625811621658edf4150638ca

####

#5

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-25 21:58 UTC  ---

This bug was previously known as _bug_ 5860 at http://redmine.yorba.org/show_bug.cgi?id=5860
Imported an attachment (id=262543)
Imported an attachment (id=262544)

Unknown Component 
   Using default product and component set in Parameters 
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.