After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 718611 - Allow thinner minimum sidebar width
Allow thinner minimum sidebar width
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other All
: High normal
: ---
Assigned To: Wolfgang Steitz
Shotwell Maintainers
: 742812 748851 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-05-06 07:45 UTC by Shotwell Maintainers
Modified: 2015-05-04 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
5214.patch (783 bytes, patch)
2012-09-14 00:59 UTC, clinton
none Details | Review
patch (774 bytes, patch)
2015-03-26 18:30 UTC, Wolfgang Steitz
accepted-commit_now Details | Review

Description Charles Lindsay 2013-11-25 21:57:13 UTC


---- Reported by shotwell-maint@gnome.bugs 2012-05-06 12:45:00 -0700 ----

Original Redmine bug id: 5214
Original URL: http://redmine.yorba.org/issues/5214
Searchable id: yorba-bug-5214
Original author: Daniel Fore
Original description:

The current minimum sidebar width is quite large when working on a smaller
display. It would be great if I could set it to something thinner, maybe more
like 160px?



---- Additional Comments From shotwell-maint@gnome.bugs 2013-09-17 12:05:00 -0700 ----

### History

####

#1

Updated by Adam Dingle over 1 year ago

  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.13_

Sounds reasonable.

####

#2

Updated by Clinton Rogers about 1 year ago

  * **File** 5214.patch added
  * **Status** changed from _Open_ to _Review_
  * **% Done** changed from _0_ to _80_

####

#3

Updated by G. W. about 1 year ago

I agree with this, but I want the ability to completely hide the sidepane even
more than this.

the same way I can press F9 key to make the sidepane disappear/appear in
Nautilus. This would be valuable feature in Shotwell as well.

####

#4

Updated by Adam Dingle about 1 year ago

  * **Status** changed from _Review_ to _Open_
  * **Target version** deleted (<strike>_0.13_</strike>)
  * **% Done** changed from _80_ to _0_

I'll review since I know Lucas is busy with another project today.
Unfortunately this approach won't work since the SIDEBAR_MIN_WIDTH constant
sets not only the sidebar's minimum width, but also its initial width when the
user first runs Shotwell. With this change, the sidebar on a new Shotwell
install is too narrow to see all dates when events are expanded.

The right way to fix this is to modify the layout code so that the sidebar's
default width is different from its minimum width.

I don't think it's worth addressing this for 0.13 at this point.

####

#5

Updated by Jens . 2 months ago

Is this perhaps worth another look? It should be possible to set the sidebar
to a smaller width (and all event or tag names should ideally overflow with
"..." at the end or the font should be horizontally compressed, so that no
horizontal scroll bar appears.

####

#6

Updated by Jim Nelson 2 months ago

  * **Category** set to _ux_

One thing that should be noted (it wasn't true when the patch was reviewed) is
that the sidebar can now be hidden with View -> Sidebar (F9).



--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC  ---

This bug was previously known as _bug_ 5214 at http://redmine.yorba.org/show_bug.cgi?id=5214
Imported an attachment (id=262428)

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Jim Nelson 2015-01-12 22:53:23 UTC
*** Bug 742812 has been marked as a duplicate of this bug. ***
Comment 2 Wolfgang Steitz 2015-03-06 23:34:44 UTC
With commit 25ed5e, sidebar items are ellipsized at the end. So even with long event names, it is now possible to have a thin sidebar. In addition, completely hiding the sidebar is also available as mentioned above. 

I think we could close this issue.
Comment 3 Jim Nelson 2015-03-06 23:48:36 UTC
Good catch!
Comment 4 Wolfgang Steitz 2015-03-26 18:30:53 UTC
Created attachment 300381 [details] [review]
patch

With the new headers only sidebar, I think it really makes sense to lower the minimum sidebar width a bit. 

In addition I removed the SIDEBAR_MAX_WIDTH from the code, it was used nowhere. The initial width is not set by SIDEBAR_MIN_WIDTH but from Config.Facade.SIDEBAR_MIN_POSITION, so we don't have a problem there.
Comment 5 Jim Nelson 2015-03-26 19:06:15 UTC
Review of attachment 300381 [details] [review]:

Commit!
Comment 6 Wolfgang Steitz 2015-03-26 19:55:00 UTC
Pushed to master, commit a91a734
Comment 7 Wolfgang Steitz 2015-05-04 08:25:34 UTC
*** Bug 748851 has been marked as a duplicate of this bug. ***