---- Reported by shotwell-maint@gnome.bugs 2012-01-12 14:22:00 -0800 ----

Original Redmine bug id: 4594
Original URL: http://redmine.yorba.org/issues/4594
Searchable id: yorba-bug-4594
Original author: Laura Khalil
Original description:

Upon exporting photos, it isn't possible to adjust the export quality. Quality
remains at High (90%) and the drop down is grayed out.



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:41:00 -0700 ----

### History

####

#1

Updated by Adam Dingle almost 2 years ago

  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.12_

####

#2

Updated by Clinton Rogers over 1 year ago

  * **Category** set to _4_
  * **% Done** changed from _0_ to _20_

There's a comment in the code that suggests this is deliberate:

    
     1        } else if (format_combo.get_active_text() == CURRENT_FORMAT_LABEL) {
     2            // if the user wishes to export the media in its current format, we allow sizing but
     3            // not JPEG quality customization, because in a batch of many photos, it's not
     4            // guaranteed that all of them will be JPEGs or RAWs that get converted to JPEGs. Some
     5            // could be PNGs, and PNG has no notion of quality. So lock out the quality control.
     6            // If the user wants to set JPEG quality, he or she can explicitly specify the JPEG
     7            // format.
     8            constraint_combo.set_sensitive(true);
     9            quality_combo.set_sensitive(false);                 /// <--- problem
    

...and again a few lines later:

    
    1            // if the user has chosen a specific format, then allow JPEG quality customization if
    2            // the format is JPEG and the user is re-sizing the image, otherwise, disallow JPEG
    3            // quality customization; always allow scaling.
    4            constraint_combo.set_sensitive(true);
    5            bool jpeg = get_specified_format() == PhotoFileFormat.JFIF;
    6            quality_combo.sensitive = !original && jpeg;    /// <--- problem
    

I have noticed that, if I set the output type to JPEG, and I change the output
size, I can choose quality at that point, but it does seem somewhat odd that
I'm not allowed to change this otherwise (some users might want this, for
example, for exporting a full-size-but-poor-quality version of a photo to obey
an image board or forum's attachment size limits).

What should happen here?

####

#3

Updated by Lucas Beeler over 1 year ago

  * **Status** changed from _Open_ to _5_
  * **Target version** deleted (<strike>_0.12_</strike>)
  * **Resolution** set to _invalid_

Just to be clear, this is the spec'd behavior. As Clinton cited in the code
comments above, the quality selector box is only supposed to be visible when
the export format is JPEG, since "quality" has no meaning for PNG, TIFF, or
(unaltered and hence exportable) RAW images. Thanks to Clinton's good
sleuthing for that comment in the code explaining the design rationale, I'm
going to mark this ticket as invalid. That said, I'm totally open to re-
spec'ing how the export dialog works if any users in the wild report being
confused by this. But as for right now, this isn't a bug; the behavior is as
specified.

####

#4

Updated by Adam Dingle over 1 year ago

  * **Status** changed from _5_ to _Open_
  * **Resolution** deleted (<strike>_invalid_</strike>)

The dialog is a bit confusing, so we should discuss this at least. Reopening.

####

#5

Updated by Paul Menzel about 1 year ago

Adam Dingle wrote:

> The dialog is a bit confusing, so we should discuss this at least.
Reopening.

I suggest, to only display »Quality« when JPEG is selected, or to give the
user a hint **why** the option is disabled. For example: »Quality (only for
JPEG)«.

####

#6

Updated by Paul Menzel about 1 year ago

This issue was assigned bug number [#688039 in the Debian
BTS](http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688039).

####

#7

Updated by Jim Nelson 11 months ago

  * **Target version** set to _0.14.0_

####

#8

Updated by Jim Nelson 11 months ago

  * **Category** set to _ux_

####

#9

Updated by Jim Nelson 10 months ago

  * **Target version** changed from _0.14.0_ to _0.15.0_

####

#10

Updated by Lucas Beeler 8 months ago

  * **Subject** changed from _Unable to adjust export quality_ to _[interim] Unable to adjust export quality_

####

#11

Updated by Jim Nelson 8 months ago

  * **Subject** changed from _[interim] Unable to adjust export quality_ to _[interim] Unable to adjust export quality when using Current file format_

To summarize, I think the solution here is (a) include text in the export
dialog box stating that the Quality field only applies to JPEGs when Current
is selected and (b) to use the specified Quality when exporting to JPEG.

####

#12

Updated by Jim Nelson 6 months ago

  * **Target version** deleted (<strike>_0.15.0_</strike>)



--- Bug imported by chaz@yorba.org 2013-11-25 21:57 UTC  ---

This bug was previously known as _bug_ 4594 at http://redmine.yorba.org/show_bug.cgi?id=4594

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution