---- Reported by shotwell-maint@gnome.bugs 2011-10-30 13:23:00 -0700 ----

Original Redmine bug id: 4326
Original URL: http://redmine.yorba.org/issues/4326
Searchable id: yorba-bug-4326
Original author: Jonas Bushart
Original description:

I think Shotwell should use the dark GTK theme if available because it
increases the contrast between the application and the images.

The image shows Shotwell with light and dark Adwaita theme and EOG.

Related issues:
related to shotwell - Task #318: support GNOME color themes (Open)
related to shotwell - 6289: Search bar not very appealing (Duplicate)



---- Additional Comments From shotwell-maint@gnome.bugs 2013-08-31 17:31:00 -0700 ----

### History

####

#1

Updated by Noran - about 2 years ago

Ok but we have to be able to choose light or dark theme.

####

#2

Updated by Jonas Bushart about 2 years ago

@Noran:

If I understand you correctly you want to have a selection e.g. in the
preferences window.

Do you dislike the dark theme or any other reason?

(Both EOG and Totem do not have this ability).

####

#3

Updated by Adam Dingle about 2 years ago

  * **Status** changed from _Open_ to _Review_
  * **Priority** changed from _Normal_ to _High_
  * **Target version** set to _0.12_

I just noticed that Jonas attached a patch to this ticket. Lucas, can you
review?

####

#4

Updated by Jonas Bushart about 2 years ago

Yeah, patch. Not realy the correct word.

Its just one line to change the behavior in the Gtk init part.

####

#5

Updated by Noran - about 2 years ago

I definitively prefer the dark theme (for Shotwell) but I suppose that some
users have a light theme for their Gnome Desktop.

I've applied your modification with a great result on my Fedora 16. Yet, basic
information panel (at left bottom) have a dirty white border.

####

#6

Updated by Jonas Bushart about 2 years ago

Ah, ok.

So to the devs: Should there be a selection for prefering dark themes?

I have no idea why there is this white border but I am going to look into the
code.

####

#7

Updated by Jonas Bushart about 2 years ago

  * **File** Shotwell_002.png added
  * **File** Shotwell_007.png added

The border is caused by bottom_frame in LibraryWindow.

We could change bottom_frame.set_shadow_type(Gtk.ShadowType.IN); (line 1321 in
library/LibraryWindow.vala) to use Gtk.ShadowType.NONE

This would be only a workaround because it will remove the border completely
(which looks not that bad).

####

#8

Updated by Noran - about 2 years ago

Thanks,

I prefer without the border.

####

#9

Updated by Lucas Beeler about 2 years ago

  * **Status** changed from _Review_ to _Open_

@ Adam:

We need to have a little product manager discussion together before deciding
to take or not to take this patch. There are pros and cons on both sides.

####

#10

Updated by Adam Dingle about 2 years ago

Jonas,

Lucas and I just tried your patch on Fedora 16. (On Ubuntu the patch has no
effect, but that's OK). We also saw the white border around the Basic
Information pane. I think that needs to be fixed somehow - simply removing the
border might be OK for now. One other problem is that the icons at the left
and right sides of the zoom slider don't look good in the dark theme. If you
can fix that as well then I think we should be able to take this patch.

####

#11

Updated by Jonas Bushart about 2 years ago

  * **Assignee** set to _Jonas Bushart_

1. I use Ubuntu. All screenshots are made with Ubuntu, so my patch works here
as well (Ubuntu 11.10)

2. White border: I have no better idea than removing the border. I have not
seen any value in the code which sets the color and I am not familiar enought
with Gtk to know another way.

3. I will look for a easy way to do this. Maybe a gtk+ app can get a value if
the dark theme is available or not. Or I will make it dependend on the
background.

####

#12

Updated by Lucas Beeler about 2 years ago

> I use Ubuntu. All screenshots are made with Ubuntu,

so my patch works here as well (Ubuntu 11.10)

You mean Ubuntu with Adwaita, right? I didn't see any effect on Ubuntu with
either of the Unity styles (Ambiance and Radiance).

####

#13

Updated by Jonas Bushart about 2 years ago

Yes, Adwaita theme.

Ambiance and Radiance do not have a dark theme.

####

#14

Updated by Adam Dingle almost 2 years ago

  * **Tracker** changed from _Feature_ to _Bug_

####

#15

Updated by Jonas Bushart over 1 year ago

  * **File** 0001-Fix-4326-use-dark-theme-if-available.patch added
  * **File** Auswahl_013.png added

Fix 4326 use dark theme if available

Use a dark Gtk theme if available

Add new zoom icons to match a dark gtk theme

Update zoom icons if style changes depending on background color of theme

(this should also use the better visible icons if the default theme is dark)

See also the small image.

####

#16

Updated by Adam Dingle over 1 year ago

  * **Status** changed from _Open_ to _Review_

Lucas, please review this latest patch - thanks!

####

#17

Updated by Lucas Beeler over 1 year ago

  * **Category** set to _4_
  * **Assignee** changed from _Jonas Bushart_ to _Lucas Beeler_
  * **Target version** changed from _0.12_ to _0.12.1_

This touches quite a few lines of code. It's too late to take it on release
day. Bumping milestone back to 0.12.1.

####

#18

Updated by Adam Dingle over 1 year ago

  * **Target version** deleted (<strike>_0.12.1_</strike>)

####

#19

Updated by Lucas Beeler 11 months ago

  * **Category** set to _ux_
  * **Status** changed from _Review_ to _Open_
  * **Assignee** changed from _Lucas Beeler_ to _Jonas Bushart_

@Jonas:

Sorry for the delay in reviewing your patch! We're still on the fence about
whether to take this patch because the "dark theme" notion doesn't affect
Unity users. That said, I know that the dark theme variation is an important
part of the GNOME Shell/Adwaita theming model, so we'd like to spend more time
running with your patch if we could. The thing is, the last version of the
patch you submitted contains a significant bug: it swaps in the lighter icons
even under Unity (see the attached screenshot). Since we ship as the default
photo manager on Ubuntu systems, looking good under unity is important to us.
Could you fix this problem and send us an updated patch?

Once again, thank you for the patch and I'm sorry it's taken us a little while
to review it.

####

#20

Updated by Lucas Beeler 11 months ago

  * **File** Light Icons.png added

####

#21

Updated by Alexander Wilms 3 months ago

I think it would be a good solution to use the symbolic versions of icons,
with the main color set to something bright.



--- Bug imported by chaz@yorba.org 2013-11-25 21:55 UTC  ---

This bug was previously known as _bug_ 4326 at http://redmine.yorba.org/show_bug.cgi?id=4326
Imported an attachment (id=262253)
Imported an attachment (id=262254)
Imported an attachment (id=262255)
Imported an attachment (id=262256)
Imported an attachment (id=262257)
Imported an attachment (id=262258)
Imported an attachment (id=262259)

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution