---- Reported by jim@yorba.org 2011-08-02 18:02:00 -0700 ----

Original Redmine bug id: 3910
Original URL: http://redmine.yorba.org/issues/3910
Searchable id: yorba-bug-3910
Original author: Jim Nelson
Original description:

I find that every time I use the Faces tool I make the same mistake and have
to restart the operation.  I do the following steps:

1. With a photo open, click Faces.

2. Drag a box around the face.

3. Type the name in the edit box.

4. Click the Ok button.  No face is added.

Instead of the face being added, the Ok button in this situation acts as a
Close or Dismiss.  What the tool is waiting for in Step 3 is for me to press
Enter, then press Ok to add the face to the database.

On one hand, I feel like there's too many steps to add a face -- I wonder if
it couldn't be more like redeye, where you add faces and then close the tool
when you're done (rather than choose Ok and have them all added at once).

On the other hand, fixing this might be as simple as desensitizing the Ok
button until the first face has been selected.  That would solve my problem
with the above steps.



---- Additional Comments From shotwell-maint@gnome.bugs 2013-01-22 14:06:00 -0800 ----

### History

####

#1

Updated by Valentín Barros over 2 years ago

  * **File** 0002-Fix-to-bug-3910.patch added

bq.

One little problem with that is that it would be more hard to undo the changes
(one by one, and the undo/redo historial would be plenty of changes related to
faces... And we would be updating the database with each face added, modified
or removed... I don't know... :S

If each Face was added via a Command it wouldn't be hard at all; undoing the
add is as simple as Edit -> Undo.  Additionally, the tool window that displays
all the added names could be used to delete a face that was just added.
Modifying the database one row at a time (or even a few rows across a few
tables) is not expensive at all; it's batch write operations where this is a
real concern.

Still, I'm not saying this is the "right" way to do this, merely one idea for
reducing the number of steps the user has to perform to add a face to the
database.  Your patch may be sufficient.

####

#2

Updated by Adam Dingle over 2 years ago

  * **Priority** changed from _Normal_ to _High_

####

#3

Updated by Jim Nelson over 2 years ago

First, oops -- I believe I edited your response, Valentin, rather than add my
response.  I intended to quote you.  Sorry about that!  Still learning
Redmine.  There might be a way to undo this, I'll look into it.

The patch looks good.  The team still needs to decide if this is the way we
want to go, but if so, then this is close.  One problem: in my quick testing,
I added a face (Ok was desensitized until I pressed Enter, good).  Then,
without pressing Ok, I deleted the face and tried adding a new one.  Ok was
sensitive throughout.

My suggestion is that Ok should only be sensitive if there is a Face to add or
remove.  This should be true on a photo with no faces to start with or one
with faces that the user decides to change.

On our end, we need to meet and discuss how to move forward with this ticket.
Go ahead and keep working on this patch in case we do decide to go this route.
I think this is close, just a few tweaks to get it right.

####

#4

Updated by Valentín Barros over 2 years ago

  * **File** 0002-Fix-to-bug-3910.patch added
  * **Priority** changed from _High_ to _Normal_

bq.

First, oops -- I believe I edited your response, Valentin, rather than add my
response.  I intended to quote you.  Sorry about that!  Still learning
Redmine.  There might be a way to undo this, I'll look into it.

Don't worry about that :S Redmine interface is a bit confusing :S

I attach a better patch --now the OK button is sensitive only when there are
changes to save. Please note that although the set_ok_button_sensitivity
method seems to be big, most of time it will be resolved simply with the first
"if".

####

#5

Updated by Valentín Barros over 2 years ago

  * **Priority** changed from _Normal_ to _High_

(Sorry, I didn't want to change the priority... Redmine seems to don't work
quite well...)

####

#6

Updated by Adam Dingle over 2 years ago

  * **Target version** deleted (<strike>_0.11_</strike>)

####

#7

Updated by Jim Nelson about 2 years ago

  * **Description** updated (diff)
  * **Status** changed from _Open_ to _Review_
  * **Target version** set to _0.12_

We have some patches here for Faces that need to be reviewed.

####

#8

Updated by Adam Dingle about 2 years ago

  * **Subject** changed from _Faces UI can be confusing_ to _[faces] Faces UI can be confusing_

####

#9

Updated by Adam Dingle almost 2 years ago

  * **Target version** deleted (<strike>_0.12_</strike>)

####

#10

Updated by Valentín Barros over 1 year ago

  * **File** 0022-Fix-to-bug-3910.patch added

Hi!

I've remade the patch I had submitted last year to apply it, if you find it
correct.

Please note that this patch should be applied after the steps I've just sent
by e-mail to recover faces tool in master.

####

#11

Updated by Jim Nelson 10 months ago

  * **Category** set to _faces_



--- Bug imported by chaz@yorba.org 2013-11-25 21:53 UTC  ---

This bug was previously known as _bug_ 3910 at http://redmine.yorba.org/show_bug.cgi?id=3910
Imported an attachment (id=262067)
Imported an attachment (id=262068)
Imported an attachment (id=262069)

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution