After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 717600 - Saved Search: dialog should disable OK button when search isn't complete
Saved Search: dialog should disable OK button when search isn't complete
Product: shotwell
Classification: Other
Component: general
Other All
: High normal
: ---
Assigned To: Eric Gregory
Shotwell Maintainers
Depends on:
Reported: 2011-04-18 09:22 UTC by Eric Gregory
Modified: 2013-05-01 06:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Charles Lindsay 2013-11-25 21:52:35 UTC

---- Reported by 2011-04-18 14:22:00 -0700 ----

Original Redmine bug id: 3515
Original URL:
Searchable id: yorba-bug-3515
Original author: Eric Gregory
Original description:

When the saved search requirements have not been met, the OK button in the
saved search dialog should be disabled.

The search name is required to have two properties:

  * Name is not null/empty string
  * Name is unique

Each type of criteria row is going to have its own requirements. For example,
it doesn't make sense for a tag name to start with the empty string.

Only when all requirements are met should the OK button be active. Likewise,
when #3511 is complete, the Close button shouldn't be active until the
requirements are met.

---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----

### History



Updated by Adam Dingle over 2 years ago

  * **Priority** set to _High_



Updated by Adam Dingle over 2 years ago

  * **Tracker** changed from _Feature_ to _Bug_



Updated by Eric Gregory over 2 years ago

  * **Status** changed from _Open_ to _5_
  * **Resolution** set to _fixed_
  * **% Done** changed from _0_ to _100_

Added in 4b0a6fb621390b1f851b0144fe24bd5beb53b1ff



Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_

--- Bug imported by 2013-11-25 21:52 UTC  ---

This bug was previously known as _bug_ 3515 at

Unknown Component 
   Using default product and component set in Parameters 
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.