---- Reported by shotwell-maint@gnome.bugs 2010-07-22 17:08:00 -0700 ----

Original Redmine bug id: 2323
Original URL: http://redmine.yorba.org/issues/2323
Searchable id: yorba-bug-2323
Original author: Josh Freeman
Original description:

The attached patch adds a Contrast setting to the color adjustments.

The contrast transformation is just a simple linear expansion/contraction from
the center of the color map; Another approach would be to add a first pass to
get the average brightness of the image in its current transformed state, then
expand/contract around that point. (IPhoto does it this way, also making some
additional adjustments around the black point, so a side-by-side comparison
can look quite different).

The latter approach is slower (along with the additional first pass, the
transformation would no longer be collapsible (RGB_MATRIX CompositionMode)),
and its effect can be approximated in the current implementation by adjusting
the Exposure setting.



---- Additional Comments From shotwell-maint@gnome.bugs 2011-01-27 10:20:00 -0800 ----

### History

####

#1

Updated by Adam Dingle over 3 years ago

  * **Priority** deleted (<strike>_High_</strike>)

####

#2

Updated by Jim Nelson over 3 years ago

  * **Priority** set to _High_

Won't be able to make 0.7; will discuss and investigate for 0.8.

####

#3

Updated by Adam Dingle over 3 years ago

Josh (tedge),

we Yorba developers discussed this patch today (we're at GUADEC in the
Netherlands!) After some discussion we concluded that we'd prefer the second
approach you mentioned, i.e. expanding/contracting around the point of average
brightness. Would you be interested in implementing that? It won't make 0.7 at
this point since we're about to freeze strings and “Contrast†is a new
string, plus we are reluctant to take new features this late in the release
cycle. But this would be a nice feature for 0.8.

####

#4

Updated by Josh Freeman over 3 years ago

Duplicate ticket

####

#5

Updated by Adam Dingle over 3 years ago

  * **Subject** changed from _[strings] Contrast color adjustment_ to _Contrast color adjustment_

####

#6

Updated by Adam Dingle about 3 years ago

  * **Priority** deleted (<strike>_High_</strike>)

We're still excited about this change, but will not quite be able to squeeze
it into 0.8 because we may need to make some infrastructure changes to reflect
the fact that the old and new transformations will be different. Dropping to
medium. Josh, we'd like to try to take all your patches for Shotwell 0.9 –
let's talk soon about that.

####

#7

Updated by Adam Dingle almost 3 years ago

  * **Priority** set to _High_



--- Bug imported by chaz@yorba.org 2013-11-25 21:46 UTC  ---

This bug was previously known as _bug_ 2323 at http://redmine.yorba.org/show_bug.cgi?id=2323
Imported an attachment (id=261761)

Unknown Component 
   Using default product and component set in Parameters 
Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution