GNOME Bugzilla – Bug 716603
possibly combine Add Tags and Modify Tags commands
Last modified: 2021-05-19 12:11:12 UTC
---- Reported by adam@yorba.org 2010-08-10 11:21:00 -0700 ---- Original Redmine bug id: 2382 Original URL: http://redmine.yorba.org/issues/2382 Searchable id: yorba-bug-2382 Original author: Adam Dingle Original description: Some users have suggested that we combine the Add Tags and Modify Tags commands into a single command. See the discussion here: http://lists.yorba.org/pipermail/shotwell/2010-July/000680.html Related issues: related to shotwell - 3715: Make it possible to change tags in multiple photos at one... (Open) related to shotwell - Feature #3415: Dragging photo(s) to tagname with CTRL should remove that... (Open) related to shotwell - Feature #4206: Modify tags for multiple images (Duplicate) related to shotwell - Task #1335: Tag bubbles (Open) related to shotwell - Task #1336: Display tags in Basic Information pane (Open) related to shotwell - Feature #7452: Shotwell lacks the ability of removing tags from multiple... (Invalid) ---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:44:00 -0700 ---- ### History #### #1 Updated by Jim Nelson about 1 year ago * **Description** updated (diff) * **Priority** changed from _Low_ to _High_ * **Target version** set to _0.14.0_ #### #2 Updated by Jim Nelson 11 months ago * **Category** set to _tags_ #### #3 Updated by Jim Nelson 11 months ago * **Target version** changed from _0.14.0_ to _0.15.0_ #### #4 Updated by Jim Nelson 8 months ago * **Target version** changed from _0.15.0_ to _0.16.0_ #### #5 Updated by Jim Nelson 6 months ago * **Target version** deleted (<strike>_0.16.0_</strike>) --- Bug imported by chaz@yorba.org 2013-11-25 21:46 UTC --- This bug was previously known as _bug_ 2382 at http://redmine.yorba.org/show_bug.cgi?id=2382 Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Created attachment 296562 [details] [review] combine add and modify tags This patch removes the "Add Tags" option from the menues. I think we do not loose any features that way. The dialogs looked the same anyhow.
Review of attachment 296562 [details] [review]: Good stuff. One thing: I noticed that the AddTagsDialog is still in the code solely for the use case where the user drops photos on the Tags container in the sidebar. Can that be migrated to use ModifyTagsDialog as well, then get rid of the extraneous dialog class?
Thinking about that a bit more. ModifyTags only works with one photo, but AddTags works with several photos at once. So just in the case of one selected photo, we don't need the two options. Might be better to keep it as is.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/shotwell/-/issues/1747.