After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 716259 - Preserve export dialog settings between sessions
Preserve export dialog settings between sessions
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other All
: Normal normal
: 0.26
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-29 06:21 UTC by Jim Nelson
Modified: 2016-10-08 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-WIP-fix-1843.patch (14.89 KB, patch)
2011-08-23 22:43 UTC, Shotwell Maintainers
none Details | Review
Persist export dialog settings (14.51 KB, patch)
2016-10-04 20:34 UTC, Jens Georg
committed Details | Review

Description Charles Lindsay 2013-11-25 21:44:30 UTC

---- Reported by jim@yorba.org 2010-04-29 11:21:00 -0700 ----

Original Redmine bug id: 1843
Original URL: http://redmine.yorba.org/issues/1843
Searchable id: yorba-bug-1843
Original author: Jim Nelson
Original description:

Preserve export dialog settings between sessions



---- Additional Comments From shotwell-maint@gnome.bugs 2011-08-23 15:43:00 -0700 ----

### History

####

#1

Updated by Jonas Bushart over 2 years ago

  * **Description** updated (diff)

I am trying to implement this feature. I use the integer values of enums like
Jpeg.Quality. Should I write serialize and unserialize methods if I use the
int values or is a typecast with (int) and (Jpeg.Quality) also ok?

####

#2

Updated by Jonas Bushart over 2 years ago

  * **File** _0001-WIP-fix-1843.patch_ added

I add my WIP patch. Getting the information into Shotwell is fully working,
only the write is missing but you could simulate it with gsettings set


Should I modify the gconf schema file also?

####

#3

Updated by Jim Nelson over 2 years ago

  * **Status** changed from _Open_ to _Review_
  * **Priority** changed from _Low_ to _Normal_

Thanks for the patch, Jonas.  Lucas, please review when you have a chance.


####

#4

Updated by Lucas Beeler about 2 years ago

  * **Status** changed from _Review_ to _Open_

Hi Jonas,

There's been a lot of activity in the Shotwell git master recently as we've
prepared for the upcoming 0.11.0 release. One consequence of all of this
activity is that your patch can no longer be applied. Could you send me an
updated patch diff'd against today's git master?


####

#5

Updated by Jonas Bushart about 2 years ago

  * **File** 0001-WIP-fix-1843.patch added

No problem. I added some parts so its good that you can review a newer
version.

But would you pleas answer the question:

bq.

I use the integer values of enums like Jpeg.Quality. Should I write serialize
and unserialize methods if I use the int values or is a typecast with (int)
and (Jpeg.Quality) also ok?

And please do not apply it into the git trunk, its WIP.

####

#6

Updated by Jonas Bushart about 2 years ago

  * **File** deleted (<strike>_0001-WIP-fix-1843.patch_</strike>)



--- Bug imported by chaz@yorba.org 2013-11-25 21:45 UTC  ---

This bug was previously known as _bug_ 1843 at http://redmine.yorba.org/show_bug.cgi?id=1843
Imported an attachment (id=261667)

Unknown Component 
   Using default product and component set in Parameters 
Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Jens Georg 2016-10-04 20:34:38 UTC
Created attachment 336950 [details] [review]
Persist export dialog settings

Updated patch against git master
Comment 2 Jens Georg 2016-10-08 14:29:41 UTC
Attachment 336950 [details] pushed as 8b95f0d - Persist export dialog settings