GNOME Bugzilla – Bug 715145
Integrate LMS plug-in
Last modified: 2016-01-17 21:33:40 UTC
https://git.gnome.org/browse/rygel/log/?h=wip/lms I filed this bug so we can keep track of the branch and so on and so I have a place where I can drop comments. First thing: If we were to integrate bug 710704 and this, together with MediaExport we'd have 3 copies of the database management code in Rygel - that's rather ugly. Also the LMS stuff shares certain similarities with the Tracker plug-in. Should we start re-designing our database-based plugins to work on common ground? Have a "DataProvider" thing that can plug either MediaExport, Tracker or LMS and does generic magic on top of that? Two issues that might arise here are: - What to do with the server-side playlists in MediaExport - What to do with the directory structure support from MediaExport
Very proactive! Agreed on both db management and to a degree on the similarities with tracker: Should try to find things to share. I've been copy-pasting on purpose so far since the code has seen some drastic changes: I'm still not sure if the lms plugin design is that great, but it does seem obvious that e.g. the db management will be very similar.
Looking at https://github.com/profusion/lightmediascanner/commit/a9ede073cde2bbb26f74e04786c55ca93bbaa540 - wouldn't it be more "elegant" to somewhat reuse the gupnp-dlna profiles?
Heads up: I'm planning to move the SqliteWrapper, Database and DatabaseCursor classes to core
Also see https://github.com/Pelagicore/Media-Manager-Rygel-LMS-Plugin For some fixes
And https://git.gnome.org/browse/rygel/log/?h=wip/lms-tizen with fixes from Tizen and rebased against master.
Btw. I had issues with "unfindable objects" because LMS does not seem to index videos very vell (missing video streams, only container information) so the join in find_object fails
Huh... How did it become critical...
*** Bug 757120 has been marked as a duplicate of this bug. ***
Hi Jens, folks, I opened this duplicate (https://bugzilla.gnome.org/show_bug.cgi?id=757120) ; the patch within basically comes from Tizen. I made a diff with https://git.gnome.org/browse/rygel/log/?h=wip/lms-tizen, and it is basically the same code :). Yes, fully duplicated work, that's what you get for not digging deep enough into branches... On my side, LMS plugin works well for .wav, .flac files .eg. ; it does not index Ogg Theora well though, but it is more likely a problem in LMS' Ogg implementation (LMS codebase, not Rygel codebse). I could try to reproduce and debug your video issue, Jens, if you give me a hint on the media files you are using. Besides this, is there anything preventing LMS plugin from being merged ?
There were some comments based on its usefulness, and despite that I'm currently trying to fix the massive code duplication regarding SQLite access, but basically it should go in this unstable cycle. Regarding the videos I have to re-check, sorry. It's been some time since I checked.
Regardng the videos, I think I accidently configured the video-dummy engine. I re-checked and with generic it works fine. But I get tons of (lt-rygel:18592): Lms-WARNING **: rygel-lms-all-videos.vala:105: Query failed: Unable to find id 2712