After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715125 - Full path of PyCairo header in pitivi/coptimizations/render.c
Full path of PyCairo header in pitivi/coptimizations/render.c
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Build and packaging
0.92
Other FreeBSD
: Normal normal
: 0.93
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-24 20:32 UTC by Olivier Duchateau
Modified: 2013-12-06 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add pycairo's CFLAGS and LIBS (1.27 KB, patch)
2013-11-24 20:32 UTC, Olivier Duchateau
none Details | Review

Description Olivier Duchateau 2013-11-24 20:32:03 UTC
Created attachment 261374 [details] [review]
Add pycairo's CFLAGS and LIBS

In pitivi/coptimizations/render.c, pycairo header is hard-coded.

Under FreeBSD (and BSD generally) it fails, because this library is located  in another PREFIX.

Patch fix this issue.
Comment 1 Olivier Duchateau 2013-11-24 20:35:46 UTC
It's compilation stage which fails (my previous comment is not complete).
Comment 2 Jean-François Fortin Tam 2013-12-01 16:54:24 UTC
Hm wait a sec... pycairo? We're using (py)GObject introspection now, this raises an eyebrow somehow.
Comment 3 Olivier Duchateau 2013-12-01 18:15:48 UTC
(In reply to comment #2)
> Hm wait a sec... pycairo? We're using (py)GObject introspection now, this
> raises an eyebrow somehow.

I know, we are using GObject Introspection, but in pitivi/coptimizations/render.c file, we can see:

#include <Python.h>
#include <stdio.h>
#include <cairo.h>
#include </usr/include/pycairo/pycairo.h>

[...]

So it needs header of Cairo python bindings.

Under FreeBSD, include/ directory is located in /usr/local

olivier@tuborg:~ $ pkgconf --variable=prefix pycairo                
/usr/local
olivier@tuborg:~ $
Comment 4 Thibault Saunier 2013-12-02 14:18:27 UTC
Please next time use git format-patch when proposing a patch, this way we can apply them easily.
Comment 5 Jean-François Fortin Tam 2013-12-06 20:38:15 UTC
For reference it seems like this has been pushed as:

commit 883683427cc449d00c631cdced2ae2306fe7168e
Author: Olivier Duchateau <olivierd@FreeBSD.org>
Date:   Mon Dec 2 11:12:08 2013 -0300

    copitmizations: Fix mistake with pycairo header import