GNOME Bugzilla – Bug 715125
Full path of PyCairo header in pitivi/coptimizations/render.c
Last modified: 2013-12-06 20:38:15 UTC
Created attachment 261374 [details] [review] Add pycairo's CFLAGS and LIBS In pitivi/coptimizations/render.c, pycairo header is hard-coded. Under FreeBSD (and BSD generally) it fails, because this library is located in another PREFIX. Patch fix this issue.
It's compilation stage which fails (my previous comment is not complete).
Hm wait a sec... pycairo? We're using (py)GObject introspection now, this raises an eyebrow somehow.
(In reply to comment #2) > Hm wait a sec... pycairo? We're using (py)GObject introspection now, this > raises an eyebrow somehow. I know, we are using GObject Introspection, but in pitivi/coptimizations/render.c file, we can see: #include <Python.h> #include <stdio.h> #include <cairo.h> #include </usr/include/pycairo/pycairo.h> [...] So it needs header of Cairo python bindings. Under FreeBSD, include/ directory is located in /usr/local olivier@tuborg:~ $ pkgconf --variable=prefix pycairo /usr/local olivier@tuborg:~ $
Please next time use git format-patch when proposing a patch, this way we can apply them easily.
For reference it seems like this has been pushed as: commit 883683427cc449d00c631cdced2ae2306fe7168e Author: Olivier Duchateau <olivierd@FreeBSD.org> Date: Mon Dec 2 11:12:08 2013 -0300 copitmizations: Fix mistake with pycairo header import