After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715117 - [PATCH] bookmarks: Update action group sensitivity
[PATCH] bookmarks: Update action group sensitivity
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-24 16:40 UTC by Volker Sobek (weld)
Modified: 2019-03-23 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bookmarks: Update action group sensitivity (2.04 KB, patch)
2013-11-24 16:40 UTC, Volker Sobek (weld) 		accepted-commit_now Details | Review
bookmarks: Update action group sensitivity (2.09 KB, patch)
2013-11-24 16:55 UTC, Volker Sobek (weld) 		none Details | Review

Description Volker Sobek (weld) 2013-11-24 16:40:03 UTC 
Fix crash that occurred on the toggle bookmark action when no document
was open. It was possible to trigger the crash because the actions for
the plugin were always sensitive, even when there was no open
document.

Additionally protect against NULL in toggle_bookmark.
Comment 1 Volker Sobek (weld) 2013-11-24 16:40:59 UTC 
Created attachment 261356 [details] [review]
 bookmarks: Update action group sensitivity

Fix crash that occurred on the toggle bookmark action when no document
was open. It was possible to trigger the crash because the actions for
the plugin were always sensitive, even when there was no open
document.

Additionally protect against NULL in toggle_bookmark.
Comment 2 Paolo Borelli 2013-11-24 16:42:48 UTC 
Review of attachment 261356 [details] [review]:

nice catch
Comment 3 Volker Sobek (weld) 2013-11-24 16:54:59 UTC 
The following fix has been pushed:
8381ae8 bookmarks: Update action group sensitivity
Comment 4 Volker Sobek (weld) 2013-11-24 16:55:03 UTC 
Created attachment 261358 [details] [review]
bookmarks: Update action group sensitivity

Fix crash that occurred on the toggle bookmark action when no document
was open. It was possible to trigger the crash because the actions for
the plugin were always sensitive, even when there was no open
document.

Additionally protect against NULL in toggle_bookmark.
Comment 5 Volker Sobek (weld) 2013-11-24 17:03:57 UTC 
Also pushed to gnome-3-10 as 7ae3bc899f4ae34e25b9d158044c6d2e3ef38029

Sorry for the second patch, I'm fighting with git bz today!