After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715116 - Buildfailure with itstool 2.0.0
Buildfailure with itstool 2.0.0
Status: VERIFIED FIXED
Product: gnome-devel-docs
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-devel-docs maintainers
gnome-devel-docs maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-24 15:52 UTC by Dominique Leuenberger
Modified: 2013-11-25 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Dominique Leuenberger 2013-11-24 15:52:54 UTC
itstool 2.0,0 has been released a while back.

With this version, gnome-devel-docs fails to build, with an error like:
Making all in hig
make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/gnome-devel-docs-3.10.2/hig'
if ! test -d "de/"; then mkdir "de/"; fi
if test -d "C"; then d="../"; else d="/home/abuild/rpmbuild/BUILD/gnome-devel-docs-3.10.2/hig/"; fi; \
mo="de/de.mo"; \
if test -f "${mo}"; then mo="../${mo}"; else mo="/home/abuild/rpmbuild/BUILD/gnome-devel-docs-3.10.2/hig/${mo}"; fi; \
(cd "de/" && itstool -m "${mo}" ${d}/C/hig-ch-bibliography.xml ${d}/C/hig-ch-checks.xml ${d}/C/hig-ch-controls.xml ${d}/C/hig-ch-credits.xml ${d}/C/hig-ch-desktop.xml ${d}/C/hig-ch-feedback.xml ${d}/C/hig-ch-gnome3.xml ${d}/C/hig-ch-icons-new.xml ${d}/C/hig-ch-icons.xml ${d}/C/hig-ch-input.xml ${d}/C/hig-ch-intro.xml ${d}/C/hig-ch-language.xml ${d}/C/hig-ch-layout.xml ${d}/C/hig-ch-menus.xml ${d}/C/hig-ch-principles.xml ${d}/C/hig-ch-toolbars.xml ${d}/C/hig-ch-windows.xml ${d}/C/hig-ch-whatsnew.xml ${d}/C/index.docbook) && \
touch "de/de.stamp"
Error: Could not merge translations:
'NoneType' object has no attribute 'isBlankNode'
make[1]: *** [de/de.stamp] Error 1
make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/gnome-devel-docs-3.10.2/hig'
make: *** [all-recursive] Error 1
Comment 1 Dominique Leuenberger 2013-11-24 15:54:16 UTC
(this is potentiall not a gnome-devel-docs issue.. I'm also investigating in direction of itstool)
Comment 2 Dominique Leuenberger 2013-11-24 18:56:35 UTC
Using some stupid try-and-error, it seems 
  hig-ch-toolbars.xml
is involved in the problem.

Dong the full itstool command without gih-ch-toolbars.xml makes it pass completely.

A quick / sillt xml syntax check does not show any error.
Comment 3 Dominique Leuenberger 2013-11-24 18:58:30 UTC
SKipping the builtin ITS rules (itstool -n) makes the error go away as well.. so the 'improved' builtin tools seem to clash somehow
Comment 4 Shaun McCance 2013-11-25 02:15:23 UTC
Thanks for reporting this. This was a bug in itstool. The bug was actually present in 1.x, but the built-in rules in 1.x didn't trigger the bug. I've committed a fix to itstool master, and I've committed a workaround to gnome-devel-docs master.
Comment 5 Dominique Leuenberger 2013-11-25 09:40:14 UTC
(In reply to comment #4)
> Thanks for reporting this. This was a bug in itstool. The bug was actually
> present in 1.x, but the built-in rules in 1.x didn't trigger the bug. I've
> committed a fix to itstool master, and I've committed a workaround to
> gnome-devel-docs master.

thanks for the quick fix! I backported the itstool fix into my itstool 2.0.1 package and gnome-devel-docs build just fine now!