After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715104 - media-tests: unit test fails
media-tests: unit test fails
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-24 12:12 UTC by Ognyan Tonchev (redstar_)
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix the failing unit test (2.89 KB, patch)
2013-11-24 12:13 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
make sure element points to a GstBin (839 bytes, patch)
2013-11-24 12:23 UTC, Ognyan Tonchev (redstar_) 		none Details | Review

Description Ognyan Tonchev (redstar_) 2013-11-24 12:12:45 UTC 
The test_media_dyn_prepare test fails after this commit: e5332535
I am proposing a fix for the test.
Comment 1 Ognyan Tonchev (redstar_) 2013-11-24 12:13:30 UTC 
Created attachment 261349 [details] [review]
fix the failing unit test
Comment 2 Ognyan Tonchev (redstar_) 2013-11-24 12:23:16 UTC 
Created attachment 261350 [details] [review]
make sure element points to a GstBin

Further on i think type must be checked for GstBin with an assert in find_payloader() since code does not support regular elements anymore.
Comment 3 Wim Taymans 2013-11-28 15:28:51 UTC 
Was already fixed by:

commit 9da7b5eeb51eccf329add863321c07e4b00f47c2
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Tue Nov 26 16:24:35 2013 +0100

    media: handle add-added on non-bins too
    
    Handle dynamic payloaders that are not bins, as used in the unit-test.