After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715093 - Fix racy build
Fix racy build
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-24 02:01 UTC by Michael Catanzaro
Modified: 2013-11-24 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix racy build (1.41 KB, patch)
2013-11-24 02:01 UTC, Michael Catanzaro 		none Details | Review
Fix racy build (1.42 KB, patch)
2013-11-24 02:02 UTC, Michael Catanzaro 		accepted-commit_now Details | Review
Don't distribute totem-pl-parser-builtins.[ch] (2.33 KB, patch)
2013-11-24 02:25 UTC, Michael Catanzaro 		accepted-commit_now Details | Review
build: don't distribute totem-pl-parser-builtins.[ch] (2.33 KB, patch)
2013-11-24 17:32 UTC, Michael Catanzaro 		committed Details | Review
build: fix a race (1.42 KB, patch)
2013-11-24 17:32 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2013-11-24 02:01:08 UTC 
totem-pl-parser-builtins.h needs to be listed in BUILT-SOURCES

make[4]: Entering directory `/home/mcatanzaro/jhbuild/src/totem-pl-parser/plparse'
  GEN      totem-pl-parser-builtins.h
  CC       libtotem_plparser_la-totem-disc.lo
  CC       libtotem_plparser_la-totem-pl-parser-amz.lo
  CC       libtotem_plparser_la-totem-pl-parser.lo
  CC       libtotem_plparser_la-totem-pl-parser-lines.lo
In file included from totem-pl-parser-amz.h:28:0,
                 from totem-pl-parser-amz.c:32:
totem-pl-parser.h:30:38: fatal error: totem-pl-parser-builtins.h: No such file or directory
 #include "totem-pl-parser-builtins.h"
                                      ^
Comment 1 Michael Catanzaro 2013-11-24 02:01:09 UTC 
Created attachment 261332 [details] [review]
Fix racy build

totem-pl-parser.h was not generated before compiling its dependencies
Comment 2 Michael Catanzaro 2013-11-24 02:02:30 UTC 
Created attachment 261333 [details] [review]
Fix racy build

totem-pl-parser-builtins.h was not generated before compiling its dependencies
Comment 3 Michael Catanzaro 2013-11-24 02:25:15 UTC 
Created attachment 261334 [details] [review]
Don't distribute totem-pl-parser-builtins.[ch]

Maybe we should not be distributing these?

They are unconditionally generated at build time, and are also listed
in CLEANFILES.
Comment 4 Bastien Nocera 2013-11-24 07:52:00 UTC 
Review of attachment 261333 [details] [review]:

Looks good.
Comment 5 Bastien Nocera 2013-11-24 07:52:22 UTC 
Review of attachment 261333 [details] [review]:

Please prefix the commit subject with "build: "
Comment 6 Bastien Nocera 2013-11-24 07:53:27 UTC 
Review of attachment 261334 [details] [review]:

Looks good. Same comment as previously, add "build: " to the commit subject
Comment 7 Michael Catanzaro 2013-11-24 17:32:21 UTC 
The following fixes have been pushed:
74d1ab5 build: don't distribute totem-pl-parser-builtins.[ch]
39e8e3d build: fix a race
Comment 8 Michael Catanzaro 2013-11-24 17:32:28 UTC 
Created attachment 261362 [details] [review]
build: don't distribute totem-pl-parser-builtins.[ch]

These are unconditionally generated at build time, and are also listed
in CLEANFILES.
Comment 9 Michael Catanzaro 2013-11-24 17:32:31 UTC 
Created attachment 261363 [details] [review]
build: fix a race

totem-pl-parser-builtins.h was not generated before compiling its dependencies