After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715071 - Updated desktop file
Updated desktop file
Status: RESOLVED FIXED
Product: atomix
Classification: Other
Component: atomix
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Atomix Maintainer(s)
Atomix Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-23 16:48 UTC by Markus Koschany
Modified: 2015-01-17 21:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
updated desktop file (827 bytes, patch)
2013-11-23 16:48 UTC, Markus Koschany 		committed Details | Review

Description Markus Koschany 2013-11-23 16:48:12 UTC 
Created attachment 261304 [details] [review]
updated desktop file

Hello,

I'm attaching a patch that creates a valid desktop file and adds some keywords too. I also recommend to use atomix-logo.png on desktop environments such as Gnome 3 because of the higher quality. 

Thanks for considering the patch.
Comment 1 Robert Roth 2015-01-10 20:27:57 UTC 
Review of attachment 261304 [details] [review]:

Thanks for your patch. However, hardcoding an absolute path for the icon location does not seem to be a good idea, as we can specify custom install prefixes. A better solution would be to install the atomix-logo.png into $INSTALL_PREFIX/share/icons/hicolor/... and that way you wouldn't have to specify a path in the desktop file, as that should be on the default icon search path.
Comment 2 Markus Koschany 2015-01-10 22:11:08 UTC 
Review of attachment 261304 [details] [review]:

You are absolutely right. Please change the line 

Icon=/usr/share/games/atomix/atomix-logo.png

to

Icon=atomix-icon

The .png suffix is superfluous and the icon just has to be installed into the appropriate hicolor directory.
Comment 3 Robert Roth 2015-01-17 21:44:16 UTC 
Thanks for the patch. Committed without the absolute path.