After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715067 - <Enter> does not save in the full name editor
<Enter> does not save in the full name editor
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
3.10.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-11-23 16:09 UTC by Michael Ekstrand
Modified: 2013-12-07 03:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to enable defaulting in the full name editor. (21.55 KB, patch)
2013-11-23 16:09 UTC, Michael Ekstrand 		committed Details | Review

Description Michael Ekstrand 2013-11-23 16:09:54 UTC 
Created attachment 261301 [details] [review]
Patch to enable defaulting in the full name editor.

In the full name editor, pressing Enter in the text fields does not activate the OK button and save the changes.

I'm attaching a patch that fixes this. I've tested it against master.  The patch noise on fullname.ui is a result of saving it in Glade; if desired, I can manually edit the fullname.ui to only set the properties in question.
Comment 1 Matthew Barnes 2013-12-06 22:03:24 UTC 
Seems to work alright.  Thanks.

Patch committed for Evolution 3.11.3 and 3.10.3:

https://git.gnome.org/browse/evolution/commit/?id=7e2b63503fe415ef1d2d745b82f6fe3269fb52e3

https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=cf687a854cc9dd84ca2bf771de548efaa20bb4ef


I notice if I open the full name editor multiple times in the same contact editor window, then Evolution crashes when I close the contact editor.  Looks like the contact editor is leaving signal handlers connected after destroying the full name dialog.

Separate but related bug, if you're interested.
Comment 2 Michael Ekstrand 2013-12-07 03:18:06 UTC 
I noticed that crash too while I was testing this patch. Haven't looked into it at all yet, though.