After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715044 - Missing keywords for the D programming language (D2)
Missing keywords for the D programming language (D2)
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other All
: Normal trivial
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-22 22:22 UTC by Mike Pedersen
Modified: 2013-11-23 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for D keywords (759 bytes, patch)
2013-11-22 22:22 UTC, Mike Pedersen 		none Details | Review
Patch that moves "immutable" and "shared" to types (1010 bytes, patch)
2013-11-23 10:46 UTC, Mike Pedersen 		committed Details | Review

Description Mike Pedersen 2013-11-22 22:22:14 UTC 
Created attachment 261275 [details] [review]
Patch for D keywords

gtksourceview currently does not have the keywords from the latest spec of the D programming language: http://dlang.org/D1toD2.html#new_keywords

I have added an attachment with a patch that should add the new keywords.
Comment 1 Paolo Borelli 2013-11-23 09:47:44 UTC 
thanks, I have applied the patch.

I do not know D but those sounds more like modifiers like "static", "const" etc... maybe should be moved in the same context or split all the modifiers in a new context?
Comment 2 Mike Pedersen 2013-11-23 10:46:56 UTC 
Created attachment 261292 [details] [review]
Patch that moves "immutable" and "shared" to types
Comment 3 Mike Pedersen 2013-11-23 10:47:55 UTC 
Oh, didn't notice there being a separate section for types. "immutable" and "shared" definitely belong there, but "pure" and "nothrow" probably does not as they apply to functions. The patch above should fix it. It also adds the __gshared modifier.
Comment 4 Paolo Borelli 2013-11-23 14:13:06 UTC 
Review of attachment 261292 [details] [review]:

committed, thank you