After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715039 - rtpjitterbuffer: Fix inconsistency in waking up
rtpjitterbuffer: Fix inconsistency in waking up
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-22 20:28 UTC by Torrie Fischer
Modified: 2013-11-25 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] rtp: jitterbuffer: Fix inconsistency in waking up (1.35 KB, patch)
2013-11-22 20:29 UTC, Torrie Fischer
committed Details | Review

Description Torrie Fischer 2013-11-22 20:28:44 UTC
When the jitterbuffer is in slave mode, the src pad task can sometimes run out
of buffers. Once that happens, the task waits for new events, but never gets
woken up until a lost buffer timeout occurs. The jitterbuffer can enter a state
of not setting up a dropped buffer timeout while still waiting for new buffers.
This change wakes up the src pad task regardless of wait reason once a new
buffer arrives on the sink pad.
Comment 1 Torrie Fischer 2013-11-22 20:29:35 UTC
Created attachment 261269 [details] [review]
[PATCH] rtp: jitterbuffer: Fix inconsistency in waking up


When the jitterbuffer is in slave mode, the src pad task can sometimes run out
of buffers. Once that happens, the task waits for new events, but never gets
woken up until a lost buffer timeout occurs. The jitterbuffer can enter a state
of not setting up a dropped buffer timeout while still waiting for new buffers.
This change wakes up the src pad task regardless of wait reason once a new
buffer arrives on the sink pad.
---
 gst/rtpmanager/gstrtpjitterbuffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Tim-Philipp Müller 2013-11-25 10:15:03 UTC
(fwiw, I pushed the fix I had pending locally since yours wasn't quite right and someone had spotted this on irc a few days ago already, I just hadn't pushed it yet because I was meaning to write a unit test for it as well.)