After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715037 - Don't enable debugging by default if the version is "unstable"
Don't enable debugging by default if the version is "unstable"
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-22 20:22 UTC by Colin Walters
Modified: 2013-11-22 20:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't enable debugging by default if the version is "unstable" (4.44 KB, patch)
2013-11-22 20:22 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2013-11-22 20:22:25 UTC
I'm open to negotiation for this, but basically...gdm is at
present second only to the kernel in the sheer amount of spew
it emits - when the version is "unstable".  But it always will
be for Continuous.

Nowadays of course, I think Continuous helps act as a testing system
for GDM that obviates a lot of the need for lots of debugging info for
gdm during "unstable" cycles.

I suspect that we will over time add other informational messages at
strategic points by default; this patch is not the end of the story.
It's a new beginning.
Comment 1 Colin Walters 2013-11-22 20:22:28 UTC
Created attachment 261267 [details] [review]
Don't enable debugging by default if the version is "unstable"
Comment 2 Ray Strode [halfline] 2013-11-22 20:28:25 UTC
Review of attachment 261267 [details] [review]:

i honestly didn't even know we did it.  I always have Enable=true in my [debug] section, and I always ask people to add it when i want debug logs.  I'm okay with dropping this code.
Comment 3 Colin Walters 2013-11-22 20:44:57 UTC
Attachment 261267 [details] pushed as cc62c15 - Don't enable debugging by default if the version is "unstable"