After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715026 - owncloud: Regular files are missing
owncloud: Regular files are missing
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on: 706798
Blocks:
 
 
Reported: 2013-11-22 16:56 UTC by Debarshi Ray
Modified: 2013-11-22 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
owncloud: Regular files are now correctly marked as such by GVfs (1.84 KB, patch)
2013-11-22 17:03 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-11-22 16:56:28 UTC 
None of the regular files on the server show up in the UI. Only directories are visible.

This is a "regression" caused by the following GVfs fix. We should now remove the workaround that we had.

commit 2b251d69351312d632e41188d5f9f7cbf394331a
Author: Ross Lagerwall <rosslagerwall@gmail.com>
Date:   Fri Oct 11 22:04:51 2013 +0200

    dav: Set file type to regular by default
    
    Some servers send empty resourcetype nodes or don't send the node at all
    for regular files (the spec says that it defaults to empty).  Set the
    file type to regular by default.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=706798
Comment 1 Debarshi Ray 2013-11-22 17:03:06 UTC 
Created attachment 261243 [details] [review]
owncloud: Regular files are now correctly marked as such by GVfs
Comment 2 Debarshi Ray 2013-11-22 17:10:44 UTC 
The fact that we should fix this GVfs bug was actually pointed out during the initial review, but I forgot about it:
https://bugzilla.gnome.org/show_bug.cgi?id=706158#c8

Sorry about that.
Comment 3 Cosimo Cecchi 2013-11-22 17:27:53 UTC 
Review of attachment 261243 [details] [review]:

Looks good to me.
Comment 4 Debarshi Ray 2013-11-22 17:37:10 UTC 
Comment on attachment 261243 [details] [review]
owncloud: Regular files are now correctly marked as such by GVfs

Thanks for the quick review!