GNOME Bugzilla – Bug 714933
Persist Conversation Viewer zoom level
Last modified: 2016-09-19 01:36:39 UTC
---- Reported by jim@yorba.org 2012-10-03 18:37:00 -0700 ---- Original Redmine bug id: 5948 Original URL: http://redmine.yorba.org/issues/5948 Searchable id: yorba-bug-5948 Original author: Jim Nelson Original description: The Conversation Viewer can be zoomed by Ctrl+MouseWheel. We should store this value in GSettings and restore it at startup. Reported at https://bugs.launchpad.net/geary/+bug/1060703 Related issues: related to geary - Feature #5949: Allow zooming in the Composer (Open) ---- Additional Comments From geary-maint@gnome.bugs 2013-04-03 18:26:00 -0700 ---- ### History #### #1 Updated by Jim Nelson 9 months ago * **Target version** changed from _0.3.0_ to _0.4.0_ #### #2 Updated by Jim Nelson 8 months ago * **Target version** changed from _0.4.0_ to _0.5.0_ --- Bug imported by chaz@yorba.org 2013-11-21 23:13 UTC --- This bug was previously known as _bug_ 5948 at http://redmine.yorba.org/show_bug.cgi?id=5948 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Here is a patch for this issue.
Created attachment 335703 [details] [review] patch proposal v1
Review of attachment 335703 [details] [review]: This looks good to go as well, but `git am` complains: > Applying: Persist Conversation Viewer zoom level. Bug 714933 > error: patch failed: src/client/conversation-viewer/conversation-web-view.vala:20 > error: src/client/conversation-viewer/conversation-web-view.vala: patch does not apply > Patch failed at 0001 Persist Conversation Viewer zoom level. Bug 714933 Which branch did you write the patch against?
Created attachment 335803 [details] [review] patch v2, without space changes ignore
I use `git format-patch --ignore-all-space` but there's a space conflict. Please tell me if I should not commit any space fix :-).
Hmm, we don't want trailing whitespace in source, but that's a lot of unrelated changes. Doesn't git have some middle ground? Would `git format-patch -b` help? If your editor can't help itself to not strip out all unrelated whitespace, then it might be easier in the long run to use `git add --patch` or a similar tool. This is usually good practice, since `git commit -a` or `git add *` is usually a bad idea. I use Emacs with whitespace-mode, which highlights unwanted whitespace, but doesn't remove it. I can then fix it up in code I'm working on, then cherry pick the changes I want for a commit using DVC (in Emacs) or Gitg (a really nice GUI for GNOME).
It turns out I could apply the original patch using `git am --whitespace=fix ...`, so I did and it seem to work fine. This has been pushed to master as 529fecd. Thanks heaps!