After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 714682 - refactor FolderList et al. to use signals instead of direct method calls
refactor FolderList et al. to use signals instead of direct method calls
Status: RESOLVED OBSOLETE
Product: geary
Classification: Other
Component: client
master
Other All
: Normal normal
: ---
Assigned To: Geary Maintainers
Geary Maintainers
Depends on: 730712
Blocks:
 
 
Reported: 2013-02-01 12:29 UTC by Charles Lindsay
Modified: 2019-01-15 05:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-21 20:28:29 UTC


---- Reported by chaz@yorba.org 2013-01-31 16:29:00 -0800 ----

Original Redmine bug id: 6301
Original URL: http://redmine.yorba.org/issues/6301
Searchable id: yorba-bug-6301
Original author: Charles Lindsay
Original description:

With the recent refactorings of Geary.Engine and Geary.Account, we may be able
to simplify a lot more client code that's still manually calling methods on
things when accounts/folders are added/removed. The idea is that if it's all
changed to simply connect to the right signal handlers, nobody has to call
those methods explicitly, so it might simplify things.

One particular spot we've talked about where this might have some benefits is
in the FolderList, but it might also be applicable to the controller and
probably lots of other places.

In the case of the FolderList, since it only cares about folders but not
accounts, we may want to think about adding more signals to Geary.Engine that
fire when any accounts available in the engine make any folders available.
That way the FolderList wouldn't have to add code to keep track of accounts at
all, just keep dealing with folders.



---- Additional Comments From geary-maint@gnome.bugs 2013-10-12 14:16:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 10 months ago

  * **Category** set to _client_

####

#2

Updated by Jim Nelson 9 months ago

  * **Target version** changed from _0.3.0_ to _0.4.0_

####

#3

Updated by Jim Nelson 6 months ago

  * **Target version** changed from _0.4.0_ to _0.5.0_

####

#4

Updated by Charles Lindsay about 1 month ago

  * **Assignee** set to _Charles Lindsay_

Eric may have taken care of this in some recent refactorings. I'll take a look
and see if there's anything left to do.

####

#5

Updated by Charles Lindsay about 1 month ago

  * **Assignee** deleted (<strike>_Charles Lindsay_</strike>)

This did not get updated with recent refactorings, and I'm not inclined to
update it now.



--- Bug imported by chaz@yorba.org 2013-11-21 20:29 UTC  ---

This bug was previously known as _bug_ 6301 at http://redmine.yorba.org/show_bug.cgi?id=6301

Unknown milestone "unknown in product geary. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 Michael Gratton 2019-01-15 05:46:46 UTC
Resolving as obsolete all bugs that should be resolved by the sidebar redesign (https://bugzilla.gnome.org/show_bug.cgi?id=730712). I'd mark them as a duplicate, but bz won't let me :(

Apologies for the noise.