GNOME Bugzilla – Bug 714659
"All Inboxes" in sidebar
Last modified: 2021-07-05 13:26:59 UTC
---- Reported by jim@yorba.org 2013-02-05 12:42:00 -0800 ---- Original Redmine bug id: 6329 Original URL: http://redmine.yorba.org/issues/6329 Searchable id: yorba-bug-6329 Original author: Jim Nelson Original description: Now that we have multiple accounts, we should have a combined "All Inboxes" entry at the top of the sidebar. Related issues: related to geary - 6331: Show account Inboxes at top of sidebar (Fixed) related to geary - Feature #6328: Combined Outbox in sidebar (Open) ---- Additional Comments From geary-maint@gnome.bugs 2013-11-12 09:41:00 -0800 ---- ### History #### #1 Updated by Jim Nelson 9 months ago * **Target version** changed from _0.3.0_ to _0.4.0_ #### #2 Updated by Jim Nelson 8 months ago * **Tracker** changed from _Bug_ to _Feature_ #### #3 Updated by Jim Nelson 8 months ago * **Target version** changed from _0.4.0_ to _0.5.0_ #### #4 Updated by Dool BR 9 days ago * **Keywords** set to _unified_ Came here to check if unified inboxes feature was on roadmap. Turned out to be called `all inboxes` here, so I'm adding the unified keyword to this ticket so more people would find this easier. Suggestion: make sure in the message list we can see from what account the message comes from. Maybe add icons or even avatars/pictures to each account and re-use them in the message list, and put it in the right lower corner of the list item box. Maybe the icons/picture can then even be used in the sidebar instead of using the account nicks? --- Bug imported by chaz@yorba.org 2013-11-21 20:29 UTC --- This bug was previously known as _bug_ 6329 at http://redmine.yorba.org/show_bug.cgi?id=6329 Unknown milestone "unknown in product geary. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Created attachment 278086 [details] [review] Starter patch To get the ball rolling on this, I'd like to suggest the attached patch as a starting point for this feature. This patch puts the consolidation logic at the presentation layer (Geary.FolderList) by: * Creating a FolderList.ConsolidatedFolderEntry class with the bulk of the functionality of FolderList:FolderEntry, but using an ArrayList of folders instead of a single folder. * Converting FolderList:FolderEntry into a subclass of FolderList:ConsoidatedFolderEntry. It becomes a wrapper passing the folder given it in the constructor to the parent class, essentially treating an entry with one folder as a trivial case of the ConsolidatedFolderEntry case. The other option is to put it in the data layer (Geary.Folder), but this feels more like a presentation than data feature to me.
I'm unsure from your message if you're aware that this patch doesn't compile due to missing symbols. It doesn't include ConsolidatedFolderEntry in the CMakeLists.txt file, but if I manually add it, that class has its own compilation errors. I'm concerned about this approach because what you're doing here only affects the sidebar. What I don't see (unless I'm missing something) is how this will display all messages from all Inboxes in the conversation list, the middle pane. I also would like to believe that this wouldn't require so much refactoring, but I haven't thought hard about the issues in the sidebar as much as the conversation list. I can think of three approaches off the top of my head: * A Geary.AggregateFolder. This virtual folder accepts existing Folders and presents their contents as a single folder. * Another possibility, one with potentially less work, is to alter App.ConversationMonitor to accept multiple folders. I say "potentially" because while it doesn't mean having to construct and entire Folder interface, the conversation monitor is not a small beastie. * Lastly, an AggregateConversationMonitor, which combines the contents of multiple ConverstionMonitors into one pool of conversations. Thinking over these three, I suspect the last one would be the easiest, but it doesn't solve every problem for the client because things like unread counts and total messages need to be aggregated from the folders, not conversations. So, the work you've already done would be useful there.
Hi, I was wondering if there was any progress on this issue as there has been no comments since 2014-06-10 and the issue has not been completed nor closed. I believe that there are many people looking forward to this new feature as this would complete the basic usage of the program.
Hi, I was also wondering if anybody is currently working on this or planning to work? I investigated the code a bit and looked at the starter patch, but so far I could get neither the starter patch or my own tweaks to compile. Apart from what Jim Nelson wrote years ago, is there a preferred way that this should be implemented?
IMO, before working on unified inboxes, we'd better wait for bug 730712 to be implemented. It contains a refined sidebar mockup which may solve several usability problems and some open bugs.
Gitlab version: https://gitlab.gnome.org/GNOME/geary/issues/53
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/geary/-/issues/ Thank you for your understanding and your help.